Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: src/compiler/js-generic-lowering.cc

Issue 1186573004: [turbofan] Remove dead code from JSGenericLowering. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-generic-lowering.cc
diff --git a/src/compiler/js-generic-lowering.cc b/src/compiler/js-generic-lowering.cc
index 51b4f10073f673f079d891b313be8e13a435f9bf..851be4923ce54f49041ebbe89983f5dc20a97644 100644
--- a/src/compiler/js-generic-lowering.cc
+++ b/src/compiler/js-generic-lowering.cc
@@ -209,35 +209,12 @@ void JSGenericLowering::ReplaceWithCompareIC(Node* node, Token::Value token) {
void JSGenericLowering::ReplaceWithStubCall(Node* node, Callable callable,
CallDescriptor::Flags flags) {
- const Operator* old_op = node->op();
- Operator::Properties properties = old_op->properties();
+ Operator::Properties properties = node->op()->properties();
CallDescriptor* desc = Linkage::GetStubCallDescriptor(
isolate(), zone(), callable.descriptor(), 0, flags, properties);
- const Operator* new_op = common()->Call(desc);
-
Node* stub_code = jsgraph()->HeapConstant(callable.code());
node->InsertInput(zone(), 0, stub_code);
- node->set_op(new_op);
-
-#if 0 && DEBUG
- // Check for at most one framestate and that it's at the right position.
- int where = -1;
- for (int index = 0; index < node->InputCount(); index++) {
- if (node->InputAt(index)->opcode() == IrOpcode::kFrameState) {
- if (where >= 0) {
- V8_Fatal(__FILE__, __LINE__,
- "node #%d:%s already has a framestate at index %d",
- node->id(), node->op()->mnemonic(), where);
- }
- where = index;
- DCHECK_EQ(NodeProperties::FirstFrameStateIndex(node), where);
- DCHECK(flags & CallDescriptor::kNeedsFrameState);
- }
- }
- if (flags & CallDescriptor::kNeedsFrameState) {
- DCHECK_GE(where, 0); // should have found a frame state.
- }
-#endif
+ node->set_op(common()->Call(desc));
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698