Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1186513002: Revert of [Android] Refactor browser test execution. (Closed)

Created:
5 years, 6 months ago by jbudorick
Modified:
5 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jbudorick+watch_chromium.org, jochen+watch_chromium.org, klundberg+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Refactor browser test execution. (patchset #14 id:260001 of https://codereview.chromium.org/1165523002/) Reason for revert: broke cronet_sample_test_apk compilation :( Original issue's description: > [Android] Refactor browser test execution. > > This change allows us to run multiple browser tests within a single > invocation of an app. It does so by moving the test activity into its > own process, running each test individually within that activity, and > killing the process between each test. > > BUG=472360 > > Committed: https://crrev.com/b049103fa4848e304102a24e78c6ba994130a535 > Cr-Commit-Position: refs/heads/master@{#334149} TBR=jochen@chromium.org,cjhopman@chromium.org,jaekyun@chromium.org,tedchoc@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=472360 Committed: https://crrev.com/de5ee37653080ea96ba50572f2241f3c8261056a Cr-Commit-Position: refs/heads/master@{#334151}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -595 lines) Patch
M build/android/pylib/gtest/gtest_test_instance.py View 7 chunks +0 lines, -68 lines 0 comments Download
M build/android/pylib/gtest/local_device_gtest_run.py View 8 chunks +39 lines, -40 lines 0 comments Download
M build/android/pylib/gtest/setup.py View 1 chunk +21 lines, -2 lines 0 comments Download
M build/android/test_runner.py View 2 chunks +0 lines, -4 lines 0 comments Download
M build/apk_test.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M build/config/android/internal_rules.gni View 1 chunk +0 lines, -8 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/test/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/test/android/browsertests_apk/AndroidManifest.xml.jinja2 View 1 chunk +1 line, -2 lines 0 comments Download
M components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsActivity.java View 2 chunks +36 lines, -16 lines 0 comments Download
M components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java View 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 2 chunks +0 lines, -16 lines 0 comments Download
D content/shell/android/browsertests/src/org/chromium/content_shell/browsertests/ContentShellBrowserTestActivity.java View 1 chunk +0 lines, -89 lines 0 comments Download
M content/shell/android/browsertests_apk/AndroidManifest.xml.jinja2 View 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsActivity.java View 2 chunks +35 lines, -19 lines 0 comments Download
M content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsApplication.java View 1 chunk +1 line, -1 line 0 comments Download
M testing/android/appurify_support/java/src/org/chromium/test/support/RobotiumBundleGenerator.java View 3 chunks +4 lines, -9 lines 0 comments Download
M testing/android/native_test.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/NativeBrowserTestActivity.java View 3 chunks +1 line, -40 lines 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/NativeTestActivity.java View 5 chunks +5 lines, -26 lines 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/NativeTestInstrumentationTestRunner.java View 6 chunks +38 lines, -189 lines 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/NativeUnitTestActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M testing/android/reporter/java/src/org/chromium/test/reporter/TestStatusReceiver.java View 7 chunks +2 lines, -28 lines 0 comments Download
M testing/android/reporter/java/src/org/chromium/test/reporter/TestStatusReporter.java View 3 chunks +8 lines, -29 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jbudorick
Created Revert of [Android] Refactor browser test execution.
5 years, 6 months ago (2015-06-12 13:18:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186513002/1
5 years, 6 months ago (2015-06-12 13:18:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-12 13:19:47 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 13:20:36 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de5ee37653080ea96ba50572f2241f3c8261056a
Cr-Commit-Position: refs/heads/master@{#334151}

Powered by Google App Engine
This is Rietveld 408576698