testing/android/appurify_support/java/src/org/chromium/test/support/RobotiumBundleGenerator.java - Issue 1186513002: Revert of [Android] Refactor browser test execution.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: testing/android/appurify_support/java/src/org/chromium/test/support/RobotiumBundleGenerator.java

Issue 1186513002: Revert of [Android] Refactor browser test execution. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsApplication.java ('k') | testing/android/native_test.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: testing/android/appurify_support/java/src/org/chromium/test/support/RobotiumBundleGenerator.java

diff --git a/testing/android/appurify_support/java/src/org/chromium/test/support/RobotiumBundleGenerator.java b/testing/android/appurify_support/java/src/org/chromium/test/support/RobotiumBundleGenerator.java

index e006954cfb2d9dedcab12dcfa3949b0562330a65..167e7b92a4f900e23b3ef0c7097d22fee9c9b323 100644

--- a/testing/android/appurify_support/java/src/org/chromium/test/support/RobotiumBundleGenerator.java

+++ b/testing/android/appurify_support/java/src/org/chromium/test/support/RobotiumBundleGenerator.java

@@ -20,7 +20,6 @@

public Bundle generate(Map<String, ResultsBundleGenerator.TestResult> rawResults) {

int testsPassed = 0;

int testsFailed = 0;

- int testsErrored = 0;

for (Map.Entry<String, ResultsBundleGenerator.TestResult> entry : rawResults.entrySet()) {

switch (entry.getValue()) {

@@ -33,9 +32,6 @@

Log.d(TAG, "FAILED: " + entry.getKey());

++testsFailed;

break;

- case UNKNOWN:

- ++testsErrored;

- break;

default:

Log.w(TAG, "Unhandled: " + entry.getKey() + ", "

+ entry.getValue().toString());

@@ -44,11 +40,10 @@

}

StringBuilder resultBuilder = new StringBuilder();

- if (testsFailed > 0 || testsErrored > 0) {

- resultBuilder.append("\nFAILURES!!! ")

- .append("Tests run: ").append(Integer.toString(rawResults.size()))

- .append(", Failures: ").append(Integer.toString(testsFailed))

- .append(", Errors: ").append(Integer.toString(testsErrored));

+ if (testsFailed > 0) {

+ resultBuilder.append(

+ "\nFAILURES!!! Tests run: " + Integer.toString(rawResults.size())

+ + ", Failures: " + Integer.toString(testsFailed) + ", Errors: 0");

} else {

resultBuilder.append("\nOK (" + Integer.toString(testsPassed) + " tests)");

}