Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1186463002: Revert of [es6] Bound function names (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [es6] Bound function names (patchset #1 id:1 of https://codereview.chromium.org/1182513002/) Reason for revert: [Sheriff] Speculative revert for changing layout tests: https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_32/379/layout-test-results/results.html Exact blame assignment is not possible as our blink bots were in a bad state for a few builds. Original issue's description: > [es6] Bound function names > > https://people.mozilla.org/~jorendorff/es6-draft.html#sec-function.prototype.bind > > Bound functions should have a name based on the function that was > bound. > > BUG=N > LOG=N > R=adamk CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/4e2a673881c55a13124dd62f2d05c8d9fe233cd3 > Cr-Commit-Position: refs/heads/master@{#28968} TBR=adamk@chromium.org,arv@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=N Committed: https://crrev.com/f2747ed9b48d0e62c7a30da69825ff926aeedbd2 Cr-Commit-Position: refs/heads/master@{#28981}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M src/v8natives.js View 2 chunks +0 lines, -5 lines 0 comments Download
D test/mjsunit/function-bind-name.js View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of [es6] Bound function names
5 years, 6 months ago (2015-06-12 06:49:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186463002/1
5 years, 6 months ago (2015-06-12 06:49:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-12 06:49:45 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 06:49:56 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2747ed9b48d0e62c7a30da69825ff926aeedbd2
Cr-Commit-Position: refs/heads/master@{#28981}

Powered by Google App Engine
This is Rietveld 408576698