Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1182513002: [es6] Bound function names (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)
Modified:
5 years, 6 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Bound function names https://people.mozilla.org/~jorendorff/es6-draft.html#sec-function.prototype.bind Bound functions should have a name based on the function that was bound. BUG=N LOG=N R=adamk CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/4e2a673881c55a13124dd62f2d05c8d9fe233cd3 Cr-Commit-Position: refs/heads/master@{#28968}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M src/v8natives.js View 2 chunks +5 lines, -0 lines 0 comments Download
A test/mjsunit/function-bind-name.js View 1 chunk +13 lines, -0 lines 1 comment Download

Messages

Total messages: 13 (3 generated)
arv (Not doing code reviews)
PTAL
5 years, 6 months ago (2015-06-11 17:13:31 UTC) #1
adamk
lgtm
5 years, 6 months ago (2015-06-11 17:41:35 UTC) #2
arv (Not doing code reviews)
Thanks. https://codereview.chromium.org/1182513002/diff/1/test/mjsunit/function-bind-name.js File test/mjsunit/function-bind-name.js (right): https://codereview.chromium.org/1182513002/diff/1/test/mjsunit/function-bind-name.js#newcode12 test/mjsunit/function-bind-name.js:12: assertEquals('bound ', fb2.name); This is kind of ugly ...
5 years, 6 months ago (2015-06-11 17:47:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182513002/1
5 years, 6 months ago (2015-06-11 20:05:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182513002/1
5 years, 6 months ago (2015-06-11 20:16:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-11 20:36:42 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4e2a673881c55a13124dd62f2d05c8d9fe233cd3 Cr-Commit-Position: refs/heads/master@{#28968}
5 years, 6 months ago (2015-06-11 20:36:59 UTC) #10
Michael Achenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1186463002/ by machenbach@chromium.org. ...
5 years, 6 months ago (2015-06-12 06:49:19 UTC) #11
Michael Achenbach
Note: In case you submitted a blink CL in the mean time, please always leave ...
5 years, 6 months ago (2015-06-12 07:06:24 UTC) #12
arv (Not doing code reviews)
5 years, 6 months ago (2015-06-12 10:08:51 UTC) #13
Message was sent while issue was closed.
On 2015/06/12 at 07:06:24, machenbach wrote:
> Note: In case you submitted a blink CL in the mean time, please always leave a
note about that on the v8-side CL, then I don't revert.

This time I didn't do a blink cl first. I didn't think blink would have tests
impacted by this but to be sure I added the blink bot.

> Note2: Your CQ_INCLUDE_TRYBOTS lacks a linebreak, otherwise the tests would
have run I guess.

Sigh.

Powered by Google App Engine
This is Rietveld 408576698