Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 1186393002: [Android log] Remove Log#makeTag (Closed)

Created:
5 years, 6 months ago by dgn
Modified:
5 years, 6 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, gunsch+watch_chromium.org, jam, jochen+watch_chromium.org, lcwu+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android log] Remove Log#makeTag The method has been deprecated for a while now. This removes it and converts the remaining usages. BUG=485772 TBR=gunsch,mmenke,nyquist Committed: https://crrev.com/7156e2a677d02b383cedac518fe7ca780ed7c697 Cr-Commit-Position: refs/heads/master@{#335556}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -53 lines) Patch
M base/android/java/src/org/chromium/base/Log.java View 1 2 chunks +0 lines, -23 lines 0 comments Download
M base/android/junit/src/org/chromium/base/LogTest.java View 1 chunk +0 lines, -14 lines 0 comments Download
M base/test/android/java/src/org/chromium/base/TestUiThread.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/externalauth/ExternalAuthUtils.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/historyreport/HistoryReportJniBridge.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/invalidation/DelayedInvalidationsController.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java_staging/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java_staging/src/org/chromium/chrome/browser/gcore/ChromeGoogleApiClientImpl.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java_staging/src/org/chromium/chrome/browser/gcore/ConnectedTask.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java_staging/src/org/chromium/chrome/browser/gsa/ContextReporter.java View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastCrashUploader.java View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/test/src/org/chromium/net/QuicTestServer.java View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/android/java/src/org/chromium/components/invalidation/PendingInvalidation.java View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsActivity.java View 2 chunks +1 line, -2 lines 0 comments Download
M device/bluetooth/android/java/src/org/chromium/device/bluetooth/BluetoothAdapter.java View 1 chunk +1 line, -1 line 0 comments Download
M net/test/android/javatests/src/org/chromium/net/test/BaseTestServer.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (8 generated)
dgn
This is a mostly mechanical change to replace a deprecated function. scheib@chromium.org: Please review changes ...
5 years, 6 months ago (2015-06-16 17:32:32 UTC) #2
scheib
//device/../BluetoothAdapter.java LGTM
5 years, 6 months ago (2015-06-16 18:00:52 UTC) #3
Yaron
lgtm
5 years, 6 months ago (2015-06-16 20:42:43 UTC) #4
dgn
darin@: PTAL at the changes in //chromecast, //components and //net
5 years, 6 months ago (2015-06-19 21:51:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186393002/20001
5 years, 6 months ago (2015-06-22 17:45:47 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_android/builds/22829)
5 years, 6 months ago (2015-06-22 18:11:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186393002/20001
5 years, 6 months ago (2015-06-22 18:23:59 UTC) #12
dgn
gunsch@ Please review changes in chromecast/.../CrashCastUploader.java mmenke@ Please review the changes in components/cronet/../QuicTestServer.java and net/../BaseTestServer.java ...
5 years, 6 months ago (2015-06-22 18:40:58 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_android/builds/22878)
5 years, 6 months ago (2015-06-22 18:42:21 UTC) #16
mmenke
On 2015/06/22 18:40:58, dgn wrote: > gunsch@ Please review changes in chromecast/.../CrashCastUploader.java > > mmenke@ ...
5 years, 6 months ago (2015-06-22 18:46:21 UTC) #17
nyquist
components/invalidation lgtm
5 years, 6 months ago (2015-06-22 19:54:07 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186393002/20001
5 years, 6 months ago (2015-06-22 20:28:25 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-22 20:57:31 UTC) #21
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 20:58:31 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7156e2a677d02b383cedac518fe7ca780ed7c697
Cr-Commit-Position: refs/heads/master@{#335556}

Powered by Google App Engine
This is Rietveld 408576698