Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: base/android/java/src/org/chromium/base/Log.java

Issue 1186393002: [Android log] Remove Log#makeTag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/android/junit/src/org/chromium/base/LogTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/java/src/org/chromium/base/Log.java
diff --git a/base/android/java/src/org/chromium/base/Log.java b/base/android/java/src/org/chromium/base/Log.java
index 38c49fc2f400063443d9da2f9a6e04d5f31ebff3..3b46cdcd65f61e6bf317475bd0dfc41ab3106398 100644
--- a/base/android/java/src/org/chromium/base/Log.java
+++ b/base/android/java/src/org/chromium/base/Log.java
@@ -4,8 +4,6 @@
package org.chromium.base;
-import android.text.TextUtils;
-
import org.chromium.base.annotations.RemovableInRelease;
import java.util.Locale;
@@ -62,27 +60,6 @@ private static String formatLogWithStack(String messageTemplate, Object... param
return "[" + getCallOrigin() + "] " + formatLog(messageTemplate, params);
}
- /**
- * Returns a full tag for the provided group tag. Full tags longer than 23 characters
- * will cause a runtime exception.
- *
- * @param groupTag {@code null} and empty string are allowed.
- *
- * @see android.util.Log#isLoggable(String, int)
- * @throws IllegalArgumentException if the tag is too long.
- * @deprecated Directly use a string (e.g. "cr.Tag") in your class. See http://crbug.com/485772
- */
- @Deprecated
- public static String makeTag(String groupTag) {
- if (TextUtils.isEmpty(groupTag)) return "cr";
- String tag = "cr." + groupTag;
- if (tag.length() > 23) {
- throw new IllegalArgumentException(
- "The full tag (" + tag + ") is longer than 23 characters.");
- }
- return tag;
- }
-
/** Convenience function, forwards to {@link android.util.Log#isLoggable(String, int)}. */
public static boolean isLoggable(String tag, int level) {
return android.util.Log.isLoggable(tag, level);
« no previous file with comments | « no previous file | base/android/junit/src/org/chromium/base/LogTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698