Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1186173005: Revert of Implement V8Platform::CallDelayedOnForegroundThread. (Closed)

Created:
5 years, 6 months ago by ulan
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement V8Platform::CallDelayedOnForegroundThread. (patchset #2 id:20001 of https://codereview.chromium.org/1181113003/) Reason for revert: We need to first roll V8 with empty implementation of the function and then use "override" here. The trick with "virtual" does not work because chromium style checks for "override". Original issue's description: > Implement V8Platform::CallDelayedOnForegroundThread. > > The corresponding change on V8 side: https://codereview.chromium.org/1179153002 > > BUG=490559 > > Committed: https://crrev.com/06c3d1b9b782c2bdb3a4e121819351f95804cea5 > Cr-Commit-Position: refs/heads/master@{#334592} TBR=jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=490559 Committed: https://crrev.com/f4f00c7a28bb5786f5dce52acf4e8bd2d39df6a2 Cr-Commit-Position: refs/heads/master@{#334794}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M gin/public/v8_platform.h View 1 chunk +0 lines, -5 lines 0 comments Download
M gin/v8_platform.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ulan
Created Revert of Implement V8Platform::CallDelayedOnForegroundThread.
5 years, 6 months ago (2015-06-17 09:05:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186173005/1
5 years, 6 months ago (2015-06-17 09:06:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 09:07:33 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 09:08:30 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4f00c7a28bb5786f5dce52acf4e8bd2d39df6a2
Cr-Commit-Position: refs/heads/master@{#334794}

Powered by Google App Engine
This is Rietveld 408576698