gin/public/v8_platform.h - Issue 1186173005: Revert of Implement V8Platform::CallDelayedOnForegroundThread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/public/v8_platform.h

Issue 1186173005: Revert of Implement V8Platform::CallDelayedOnForegroundThread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gin/public/v8_platform.h

diff --git a/gin/public/v8_platform.h b/gin/public/v8_platform.h

index 3e90059cb792202c9a62fa0153fa2d01ef694a54..a4fc28a9bc32cf394af4027cddfc116a85219fd1 100644

--- a/gin/public/v8_platform.h

+++ b/gin/public/v8_platform.h

@@ -23,11 +23,6 @@

v8::Task* task,

v8::Platform::ExpectedRuntime expected_runtime) override;

void CallOnForegroundThread(v8::Isolate* isolate, v8::Task* task) override;

- // TODO(ulan): Replace 'virtual' with 'override' once the corresponding change

- // in V8 rolls in chromium.

- virtual void CallDelayedOnForegroundThread(v8::Isolate* isolate,

- v8::Task* task,

- double delay_in_seconds);

double MonotonicallyIncreasingTime() override;

private:

« no previous file with comments | « no previous file | gin/v8_platform.cc » ('j') | no next file with comments »