Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1186053007: Fix 'fetch blink' recipe for proper management. (Closed)

Created:
5 years, 6 months ago by agable
Modified:
5 years, 5 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix 'fetch blink' recipe for proper management. This both ensures that 'git auto-svn' has been properly run, and also that the Blink checkout is appropriately 'unmanaged'. R=dpranke@chromium.org, mmoss@chromium.org BUG=289742 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295916

Patch Set 1 #

Patch Set 2 : remove prints #

Patch Set 3 : install-build-deps #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -12 lines) Patch
M recipes/blink.py View 1 2 3 1 chunk +28 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
agable
5 years, 6 months ago (2015-06-15 19:13:38 UTC) #1
Dirk Pranke
lgtm
5 years, 6 months ago (2015-06-15 21:02:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186053007/60001
5 years, 5 months ago (2015-07-02 16:32:04 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 16:33:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295916

Powered by Google App Engine
This is Rietveld 408576698