Source/bindings/scripts/v8_attributes.py - Issue 1185843010: bindings: Moves custom getters/setters to the prototype chain.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_attributes.py

Issue 1185843010: bindings: Moves custom getters/setters to the prototype chain. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Addressed a review comment. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/v8_attributes.py

diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py

index 4980307e80e1956d842690cb081b4b05bcd443da..b1f72a0a9abc82ea9cd6e55ebaeed43c84fafa39 100644

--- a/Source/bindings/scripts/v8_attributes.py

+++ b/Source/bindings/scripts/v8_attributes.py

@@ -519,11 +519,8 @@ def is_expose_js_accessors(interface, attribute):

'OverrideBuiltins' in interface.extended_attributes):

return False

- # FIXME: We should move all of the following DOM attributes to prototype

- # chains.

- if (has_custom_getter(attribute) or

- has_custom_setter(attribute) or

- interface.name == 'Window'):

+ # The members of Window interface must be placed on the instance object.

+ if interface.name == 'Window':

return False

return is_accessor