Source/bindings/scripts/v8_utilities.py - Issue 1185843010: bindings: Moves custom getters/setters to the prototype chain.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_utilities.py

Issue 1185843010: bindings: Moves custom getters/setters to the prototype chain. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Addressed a review comment. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/v8_utilities.py

diff --git a/Source/bindings/scripts/v8_utilities.py b/Source/bindings/scripts/v8_utilities.py

index 52da18f481ce1074803963441af758e996a08ec2..1cd44abbe378c6d69e80cb8f24d0d6a28e0f9958 100644

--- a/Source/bindings/scripts/v8_utilities.py

+++ b/Source/bindings/scripts/v8_utilities.py

@@ -468,11 +468,6 @@ def on_prototype(interface, member):

if (interface.name == 'Window'):

return member.idl_type.name == 'EventHandler'

- # TODO(yukishiino): We should move all of the following members to prototype

- # chains.

- if 'Custom' in member.extended_attributes:

- return False

if 'ExposeJSAccessors' in interface.extended_attributes:

return True

if 'DoNotExposeJSAccessors' in interface.extended_attributes:

« no previous file with comments | « Source/bindings/scripts/v8_attributes.py ('k') | Source/bindings/templates/interface.h » ('j') | no next file with comments »