Source/bindings/core/v8/custom/V8HTMLOptionsCollectionCustom.cpp - Issue 1185843010: bindings: Moves custom getters/setters to the prototype chain.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/custom/V8HTMLOptionsCollectionCustom.cpp

Issue 1185843010: bindings: Moves custom getters/setters to the prototype chain. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Addressed a review comment. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/custom/V8HTMLOptionsCollectionCustom.cpp

diff --git a/Source/bindings/core/v8/custom/V8HTMLOptionsCollectionCustom.cpp b/Source/bindings/core/v8/custom/V8HTMLOptionsCollectionCustom.cpp

index 360f4e227955260b3a451a315386bafcd5e7c1b6..4e11ce93581e911add1fbb6eb3bc36ed93bb5de1 100644

--- a/Source/bindings/core/v8/custom/V8HTMLOptionsCollectionCustom.cpp

+++ b/Source/bindings/core/v8/custom/V8HTMLOptionsCollectionCustom.cpp

@@ -43,7 +43,7 @@

namespace blink {

-void V8HTMLOptionsCollection::lengthAttributeSetterCustom(v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<void>& info)

+void V8HTMLOptionsCollection::lengthAttributeSetterCustom(v8::Local<v8::Value> value, const v8::FunctionCallbackInfo<v8::Value>& info)

{

HTMLOptionsCollection* impl = V8HTMLOptionsCollection::toImpl(info.Holder());

unsigned newLength = 0;