Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: Source/bindings/core/v8/custom/V8ErrorEventCustom.cpp

Issue 1185843010: bindings: Moves custom getters/setters to the prototype chain. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed a review comment. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/custom/V8ErrorEventCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8ErrorEventCustom.cpp b/Source/bindings/core/v8/custom/V8ErrorEventCustom.cpp
index 0dc19a553193660c94f96dde67c097883fa8655c..c85cba2d441cd8ef5355fbb8b39a232642804f4b 100644
--- a/Source/bindings/core/v8/custom/V8ErrorEventCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8ErrorEventCustom.cpp
@@ -43,13 +43,13 @@
namespace blink {
-static void setHiddenValueAndReturnValue(const v8::PropertyCallbackInfo<v8::Value>& info, v8::Local<v8::Value> error)
+static void setHiddenValueAndReturnValue(const v8::FunctionCallbackInfo<v8::Value>& info, v8::Local<v8::Value> error)
{
V8HiddenValue::setHiddenValue(info.GetIsolate(), info.Holder(), V8HiddenValue::error(info.GetIsolate()), error);
v8SetReturnValue(info, error);
}
-void V8ErrorEvent::errorAttributeGetterCustom(const v8::PropertyCallbackInfo<v8::Value>& info)
+void V8ErrorEvent::errorAttributeGetterCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
{
v8::Isolate* isolate = info.GetIsolate();
v8::Local<v8::Value> cachedError = V8HiddenValue::getHiddenValue(isolate, info.Holder(), V8HiddenValue::error(isolate));

Powered by Google App Engine
This is Rietveld 408576698