Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 1185833003: Revert of Disable SitePerProcess tests that are incompatible with Blink fix. (Closed)

Created:
5 years, 6 months ago by Charlie Reis
Modified:
5 years, 6 months ago
Reviewers:
nasko
CC:
chromium-reviews, darin-cc_chromium.org, jam, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable SitePerProcess tests that are incompatible with Blink fix. (patchset #1 id:1 of https://codereview.chromium.org/1180013002/) Reason for revert: These should pass now that https://codereview.chromium.org/1173513002/ and https://codereview.chromium.org/1143653002/ have landed. Original issue's description: > Disable SitePerProcess tests that are incompatible with Blink fix. > > These will be updated and re-enabled once the first real commit type > for subframes in Blink is fixed. > > BUG=498559 > TEST=Tree stays green after https://codereview.chromium.org/1173513002/. > > Committed: https://crrev.com/b220cf91b8e8c094a2a81b5fb826f809aac9bf21 > Cr-Commit-Position: refs/heads/master@{#334087} TBR=nasko@chromium.org BUG=498559 Committed: https://crrev.com/20140791d42e1f46a08308c1d15e562bc6e04e36 Cr-Commit-Position: refs/heads/master@{#334395}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M content/browser/site_per_process_browsertest.cc View 2 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Charlie Reis
Created Revert of Disable SitePerProcess tests that are incompatible with Blink fix.
5 years, 6 months ago (2015-06-15 16:29:43 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185833003/1
5 years, 6 months ago (2015-06-15 16:32:45 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-15 16:56:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185833003/1
5 years, 6 months ago (2015-06-15 16:58:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-15 17:06:39 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 17:07:35 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20140791d42e1f46a08308c1d15e562bc6e04e36
Cr-Commit-Position: refs/heads/master@{#334395}

Powered by Google App Engine
This is Rietveld 408576698