Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Side by Side Diff: content/browser/site_per_process_browsertest.cc

Issue 1185833003: Revert of Disable SitePerProcess tests that are incompatible with Blink fix. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/site_per_process_browsertest.h" 5 #include "content/browser/site_per_process_browsertest.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 545 matching lines...) Expand 10 before | Expand all | Expand 10 after
556 EXPECT_EQ( 556 EXPECT_EQ(
557 " Site A ------------ proxies for B C\n" 557 " Site A ------------ proxies for B C\n"
558 " |--Site B ------- proxies for A C\n" 558 " |--Site B ------- proxies for A C\n"
559 " +--Site C ------- proxies for A B\n" 559 " +--Site C ------- proxies for A B\n"
560 "Where A = http://127.0.0.1/\n" 560 "Where A = http://127.0.0.1/\n"
561 " B = http://foo.com/ (no process)\n" 561 " B = http://foo.com/ (no process)\n"
562 " C = http://bar.com/", 562 " C = http://bar.com/",
563 DepictFrameTree(root)); 563 DepictFrameTree(root));
564 } 564 }
565 565
566 // TODO(creis): Fix and enable once initial subframe loads are fixed in Blink.
567 // See https://crbug.com/498559.
568 IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest, 566 IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest,
569 DISABLED_NavigateRemoteFrame) { 567 NavigateRemoteFrame) {
570 GURL main_url(embedded_test_server()->GetURL("/site_per_process_main.html")); 568 GURL main_url(embedded_test_server()->GetURL("/site_per_process_main.html"));
571 NavigateToURL(shell(), main_url); 569 NavigateToURL(shell(), main_url);
572 570
573 // It is safe to obtain the root frame tree node here, as it doesn't change. 571 // It is safe to obtain the root frame tree node here, as it doesn't change.
574 FrameTreeNode* root = 572 FrameTreeNode* root =
575 static_cast<WebContentsImpl*>(shell()->web_contents())-> 573 static_cast<WebContentsImpl*>(shell()->web_contents())->
576 GetFrameTree()->root(); 574 GetFrameTree()->root();
577 575
578 TestNavigationObserver observer(shell()->web_contents()); 576 TestNavigationObserver observer(shell()->web_contents());
579 577
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
613 611
614 // Navigate back to the parent's origin and ensure we return to the 612 // Navigate back to the parent's origin and ensure we return to the
615 // parent's process. 613 // parent's process.
616 NavigateFrameToURL(child, http_url); 614 NavigateFrameToURL(child, http_url);
617 EXPECT_EQ(http_url, observer.last_navigation_url()); 615 EXPECT_EQ(http_url, observer.last_navigation_url());
618 EXPECT_TRUE(observer.last_navigation_succeeded()); 616 EXPECT_TRUE(observer.last_navigation_succeeded());
619 EXPECT_EQ(shell()->web_contents()->GetSiteInstance(), 617 EXPECT_EQ(shell()->web_contents()->GetSiteInstance(),
620 child->current_frame_host()->GetSiteInstance()); 618 child->current_frame_host()->GetSiteInstance());
621 } 619 }
622 620
623 // TODO(creis): Fix and enable once initial subframe loads are fixed in Blink. 621 #if defined(OS_WIN)
624 // See https://crbug.com/498559. 622 // http://crbug.com/465722
625 // Also disabled on Windows for https://crbug.com/465722. 623 #define MAYBE_NavigateRemoteFrameToBlankAndDataURLs \
624 DISABLED_NavigateRemoteFrameToBlankAndDataURLs
625 #else
626 #define MAYBE_NavigateRemoteFrameToBlankAndDataURLs \
627 NavigateRemoteFrameToBlankAndDataURLs
628 #endif
629
626 IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest, 630 IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest,
627 DISABLED_NavigateRemoteFrameToBlankAndDataURLs) { 631 MAYBE_NavigateRemoteFrameToBlankAndDataURLs) {
628 GURL main_url(embedded_test_server()->GetURL("/site_per_process_main.html")); 632 GURL main_url(embedded_test_server()->GetURL("/site_per_process_main.html"));
629 NavigateToURL(shell(), main_url); 633 NavigateToURL(shell(), main_url);
630 634
631 // It is safe to obtain the root frame tree node here, as it doesn't change. 635 // It is safe to obtain the root frame tree node here, as it doesn't change.
632 FrameTreeNode* root = 636 FrameTreeNode* root =
633 static_cast<WebContentsImpl*>(shell()->web_contents())-> 637 static_cast<WebContentsImpl*>(shell()->web_contents())->
634 GetFrameTree()->root(); 638 GetFrameTree()->root();
635 639
636 TestNavigationObserver observer(shell()->web_contents()); 640 TestNavigationObserver observer(shell()->web_contents());
637 641
(...skipping 1883 matching lines...) Expand 10 before | Expand all | Expand 10 after
2521 " |--Site A\n" 2525 " |--Site A\n"
2522 " +--Site A\n" 2526 " +--Site A\n"
2523 " |--Site A\n" 2527 " |--Site A\n"
2524 " +--Site A\n" 2528 " +--Site A\n"
2525 " +--Site A\n" 2529 " +--Site A\n"
2526 "Where A = http://127.0.0.1/", 2530 "Where A = http://127.0.0.1/",
2527 DepictFrameTree(root)); 2531 DepictFrameTree(root));
2528 } 2532 }
2529 2533
2530 } // namespace content 2534 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698