Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 11858022: Merge 138162 (Closed)

Created:
7 years, 11 months ago by kerz_chromium
Modified:
7 years, 11 months ago
Reviewers:
commit-queue
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 138162 > Text Autosizing: Work out what to do about form controls > https://bugs.webkit.org/show_bug.cgi?id=102560 > > Patch by Tim Volodine <timvolodine@chromium.org>; on 2012-12-19 > Reviewed by Kenneth Rohde Christiansen. > > Source/WebCore: > > Disallow autosizing of form input controls like buttons, text input fields, selection controls, radio buttons > and check boxes. This is a short term solution to avoid inconsistent autosizing of form controls (which is > worse than not autosizing at all). > > Tests: fast/text-autosizing/form-controls-autosizing-button-input-elements.html > fast/text-autosizing/form-controls-autosizing-checkbox-input-element.html > fast/text-autosizing/form-controls-autosizing-radio-input-element.html > fast/text-autosizing/form-controls-autosizing-select-element.html > fast/text-autosizing/form-controls-autosizing-textfield-input-elements.html > > * rendering/TextAutosizer.cpp: > (WebCore): > (WebCore::formInputTags): > (WebCore::TextAutosizer::isAutosizingContainer): > (WebCore::TextAutosizer::contentHeightIsConstrained): > (WebCore::TextAutosizer::containerShouldBeAutosized): > (WebCore::TextAutosizer::containerContainsOneOfTags): > * rendering/TextAutosizer.h: > > LayoutTests: > > Tests for form input elements autosizing. Added tests to check that various kinds of form elements > don't get autosized, i.e. buttons, textareas, check boxes, radio button and selection menus. > > * fast/text-autosizing/form-controls-autosizing-button-input-elements-expected.html: Added. > * fast/text-autosizing/form-controls-autosizing-button-input-elements.html: Added. > * fast/text-autosizing/form-controls-autosizing-checkbox-input-element-expected.html: Added. > * fast/text-autosizing/form-controls-autosizing-checkbox-input-element.html: Added. > * fast/text-autosizing/form-controls-autosizing-radio-input-element-expected.html: Added. > * fast/text-autosizing/form-controls-autosizing-radio-input-element.html: Added. > * fast/text-autosizing/form-controls-autosizing-select-element-expected.html: Added. > * fast/text-autosizing/form-controls-autosizing-select-element.html: Added. > * fast/text-autosizing/form-controls-autosizing-textfield-input-elements-expected.html: Added. > * fast/text-autosizing/form-controls-autosizing-textfield-input-elements.html: Added. TBR=commit-queue@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139476

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -3 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +22 lines, -1 line 0 comments Download
A + LayoutTests/fast/text-autosizing/form-controls-autosizing-button-input-elements.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/text-autosizing/form-controls-autosizing-button-input-elements-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/text-autosizing/form-controls-autosizing-checkbox-input-element.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/text-autosizing/form-controls-autosizing-checkbox-input-element-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/text-autosizing/form-controls-autosizing-radio-input-element.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/text-autosizing/form-controls-autosizing-radio-input-element-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/text-autosizing/form-controls-autosizing-select-element.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/text-autosizing/form-controls-autosizing-select-element-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/text-autosizing/form-controls-autosizing-textfield-input-elements.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/text-autosizing/form-controls-autosizing-textfield-input-elements-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/ChangeLog View 1 chunk +27 lines, -1 line 0 comments Download
M Source/WebCore/rendering/TextAutosizer.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/WebCore/rendering/TextAutosizer.cpp View 5 chunks +51 lines, -11 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
kerz_chromium
7 years, 11 months ago (2013-01-11 19:47:11 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698