Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1088)

Unified Diff: content/renderer/gpu/gpu_benchmarking_extension.cc

Issue 11858007: Splits SmoothGestureController from RenderWidgetHostImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Single smooth scroll Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/gpu/gpu_benchmarking_extension.cc
diff --git a/content/renderer/gpu/gpu_benchmarking_extension.cc b/content/renderer/gpu/gpu_benchmarking_extension.cc
index 7fa3823d37c89088347f28243c52e0c0159facf7..042adb9f5f12553668c165fbc650703c222c956d 100644
--- a/content/renderer/gpu/gpu_benchmarking_extension.cc
+++ b/content/renderer/gpu/gpu_benchmarking_extension.cc
@@ -305,16 +305,14 @@ class GpuBenchmarkingWrapper : public v8::Extension {
// TODO(nduca): If the render_view_impl is destroyed while the gesture is in
// progress, we will leak the callback and context. This needs to be fixed,
// somehow.
- render_view_impl->BeginSmoothScroll(
+ return render_view_impl->BeginSmoothScroll(
scroll_down,
base::Bind(&OnSmoothScrollCompleted,
callback,
context),
pixels_to_scroll,
mouse_event_x,
- mouse_event_y);
-
- return v8::True();
+ mouse_event_y) ? v8::True() : v8::False();
}
static v8::Handle<v8::Value> RunRenderingBenchmarks(

Powered by Google App Engine
This is Rietveld 408576698