Splits SmoothGestureController from RenderWidgetHostImpl

content/common/view_messages.h

Index: content/common/view_messages.h
diff --git a/content/common/view_messages.h b/content/common/view_messages.h
index ccc2ac60692608569bb9d5ff295738ba11944ced..7ab924107e9a3d78383433cdc15887d69671d70a 100644
--- a/content/common/view_messages.h
+++ b/content/common/view_messages.h
@@ -847,8 +847,7 @@ IPC_MESSAGE_ROUTED2(ViewMsg_HandleInputEvent,
                     bool /* is_keyboard_shortcut */)
 
 // Tells the render widget that a smooth scroll completed.
-IPC_MESSAGE_ROUTED1(ViewMsg_SmoothScrollCompleted,
-                    int /* gesture_id */)
+IPC_MESSAGE_ROUTED0(ViewMsg_SmoothScrollCompleted)

[rjkroege, 2013/02/21 19:26:33]

using a RenderViewHostObserver could save you needing to add this here too?

[bulach, 2013/02/22 16:55:14]

hmm.. this is just being changed, not added, but anyways.. :)
I can move this to a separate file, say "smooth_scroll_messages.h" if you
prefer?
however, as for making the |gesture controller| a RenderViewHostObserver, I'm
not quite clear if that would be worth it: my understanding is that this needs
to be hooked at RenderWidgetHostImpl, which is a parallel hierarchy to
RenderViewHost, so it wouldn't be possible to instantiate the |gesture
controller| at construction time... I mean, my understanding is that it'd be
only possible after the bottom of the diamond, |RenderViewHostImpl|, is
instantiated.

however, I may have missed some "view x host x impl" combination here, please
let me know if this is simpler than I'm seeing :)

 
 // This message notifies the renderer that the next key event is bound to one
 // or more pre-defined edit commands. If the next key event is not handled
@@ -1679,9 +1678,9 @@ IPC_STRUCT_BEGIN(ViewHostMsg_BeginSmoothScroll_Params)
   IPC_STRUCT_MEMBER(int, mouse_event_y)
 IPC_STRUCT_END()
 
-IPC_MESSAGE_ROUTED2(ViewHostMsg_BeginSmoothScroll,
-                    int /* gesture_id */,
-                    ViewHostMsg_BeginSmoothScroll_Params /* params */)
+IPC_SYNC_MESSAGE_ROUTED1_1(ViewHostMsg_BeginSmoothScroll,
+                           ViewHostMsg_BeginSmoothScroll_Params /* params */,
+                           bool /* smooth_scroll_started */)
 
 IPC_MESSAGE_ROUTED0(ViewHostMsg_Focus)
 IPC_MESSAGE_ROUTED0(ViewHostMsg_Blur)