Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 1185783008: Remove fixed header at chrome://inspect (Closed)

Created:
5 years, 6 months ago by robwu
Modified:
5 years, 6 months ago
Reviewers:
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2403
Target Ref:
refs/pending/branch-heads/2403
Project:
chromium
Visibility:
Public.

Description

Remove fixed header at chrome://inspect The fixed header gets in the way when the user zooms in and attempts to scroll the page. To fix this issue, the header is no longer at a viewport-fixed position, but at a static position within the main content. The location specified by the page header is already displayed in the left navigation bar, so this change does not hurt usability. BUG=492124 Review URL: https://codereview.chromium.org/1187813004 Cr-Commit-Position: refs/heads/master@{#334722} (cherry picked from commit 0d96227ee3378a3b0676f7923560c69f0a8209c7) Committed: https://chromium.googlesource.com/chromium/src/+/56cc9bd9cd4b010789298c8200170b06dd599c54

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M chrome/browser/resources/inspect/inspect.css View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
robwu
5 years, 6 months ago (2015-06-17 22:36:13 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
56cc9bd9cd4b010789298c8200170b06dd599c54.

Powered by Google App Engine
This is Rietveld 408576698