Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1187813004: Remove fixed header at chrome://inspect (Closed)

Created:
5 years, 6 months ago by robwu
Modified:
5 years, 6 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove fixed header at chrome://inspect The fixed header gets in the way when the user zooms in and attempts to scroll the page. To fix this issue, the header is no longer at a viewport-fixed position, but at a static position within the main content. The location specified by the page header is already displayed in the left navigation bar, so this change does not hurt usability. BUG=492124 Committed: https://crrev.com/0d96227ee3378a3b0676f7923560c69f0a8209c7 Cr-Commit-Position: refs/heads/master@{#334722}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M chrome/browser/resources/inspect/inspect.css View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
robwu
Yet another CL for chrome://inspect/... To manually test the changes: 1. get Canary 2. Visit ...
5 years, 6 months ago (2015-06-15 16:39:50 UTC) #2
pfeldman
lgtm
5 years, 6 months ago (2015-06-16 18:40:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187813004/1
5 years, 6 months ago (2015-06-16 20:49:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-16 22:40:45 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 22:42:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d96227ee3378a3b0676f7923560c69f0a8209c7
Cr-Commit-Position: refs/heads/master@{#334722}

Powered by Google App Engine
This is Rietveld 408576698