Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1122)

Unified Diff: chrome/browser/autocomplete/zero_suggest_provider.cc

Issue 1185723002: Prepare HistoryProvider for componentization (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to review Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/zero_suggest_provider.cc
diff --git a/chrome/browser/autocomplete/zero_suggest_provider.cc b/chrome/browser/autocomplete/zero_suggest_provider.cc
index 812cef888ab6c5315f4e9b372046356d2a317471..b3d1d9c8aaaf9a86d7265f554537b2ab2f94f145 100644
--- a/chrome/browser/autocomplete/zero_suggest_provider.cc
+++ b/chrome/browser/autocomplete/zero_suggest_provider.cc
@@ -78,8 +78,10 @@ const int kDefaultZeroSuggestRelevance = 100;
ZeroSuggestProvider* ZeroSuggestProvider::Create(
AutocompleteProviderListener* listener,
TemplateURLService* template_url_service,
- Profile* profile) {
- return new ZeroSuggestProvider(listener, template_url_service, profile);
+ Profile* profile,
+ AutocompleteProviderClient* client) {
+ return new ZeroSuggestProvider(listener, template_url_service, profile,
+ client);
}
// static
@@ -121,7 +123,7 @@ void ZeroSuggestProvider::Start(const AutocompleteInput& input,
// most visited field trials.
if (CanSendURL(input.current_url(), suggest_url, default_provider,
current_page_classification_,
- template_url_service_->search_terms_data(), client_.get()) &&
+ template_url_service_->search_terms_data(), client_) &&
!OmniboxFieldTrial::InZeroSuggestPersonalizedFieldTrial() &&
!OmniboxFieldTrial::InZeroSuggestMostVisitedFieldTrial()) {
// Update suggest_url to include the current_page_url.
@@ -189,12 +191,12 @@ void ZeroSuggestProvider::ResetSession() {
}
ZeroSuggestProvider::ZeroSuggestProvider(
- AutocompleteProviderListener* listener,
- TemplateURLService* template_url_service,
- Profile* profile)
+ AutocompleteProviderListener* listener,
+ TemplateURLService* template_url_service,
+ Profile* profile,
+ AutocompleteProviderClient* client)
: BaseSearchProvider(template_url_service,
- scoped_ptr<AutocompleteProviderClient>(
- new ChromeAutocompleteProviderClient(profile)),
+ client,
AutocompleteProvider::TYPE_ZERO_SUGGEST),
listener_(listener),
profile_(profile),
@@ -444,8 +446,7 @@ bool ZeroSuggestProvider::ShouldShowNonContextualZeroSuggest(
if (!ZeroSuggestEnabled(suggest_url,
template_url_service_->GetDefaultSearchProvider(),
current_page_classification_,
- template_url_service_->search_terms_data(),
- client_.get()))
+ template_url_service_->search_terms_data(), client_))
return false;
// If we cannot send URLs, then only the MostVisited and Personalized

Powered by Google App Engine
This is Rietveld 408576698