Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: chrome/browser/autocomplete/zero_suggest_provider_unittest.cc

Issue 1185723002: Prepare HistoryProvider for componentization (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to review Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/zero_suggest_provider_unittest.cc
diff --git a/chrome/browser/autocomplete/zero_suggest_provider_unittest.cc b/chrome/browser/autocomplete/zero_suggest_provider_unittest.cc
index 105efe7d388fe5a794814a71b2a1a6947f14f311..915ef2b190ff114f6215b7f60edbc6de53732071 100644
--- a/chrome/browser/autocomplete/zero_suggest_provider_unittest.cc
+++ b/chrome/browser/autocomplete/zero_suggest_provider_unittest.cc
@@ -9,6 +9,7 @@
#include "base/run_loop.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/autocomplete/autocomplete_classifier_factory.h"
+#include "chrome/browser/autocomplete/chrome_autocomplete_provider_client.h"
#include "chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.h"
#include "chrome/browser/history/top_sites_factory.h"
#include "chrome/browser/search_engines/template_url_service_factory.h"
@@ -148,6 +149,9 @@ class ZeroSuggestProviderTest : public testing::Test,
// Profile we use.
TestingProfile profile_;
+ // ProviderClient we use.
Peter Kasting 2015/06/16 00:03:42 Nit: Same comment as in search_provider_unittest.c
blundell 2015/06/16 07:21:25 Done.
+ scoped_ptr<ChromeAutocompleteProviderClient> client_;
+
// ZeroSuggestProvider object under test.
scoped_refptr<ZeroSuggestProvider> provider_;
@@ -167,6 +171,8 @@ void ZeroSuggestProviderTest::SetUp() {
AutocompleteClassifierFactory::GetInstance()->SetTestingFactoryAndUse(
&profile_, &AutocompleteClassifierFactory::BuildInstanceFor);
+ client_.reset(new ChromeAutocompleteProviderClient(&profile_));
+
TemplateURLService* turl_model =
TemplateURLServiceFactory::GetForProfile(&profile_);
turl_model->Load();
@@ -183,7 +189,8 @@ void ZeroSuggestProviderTest::SetUp() {
TopSitesFactory* top_sites_factory = TopSitesFactory::GetInstance();
top_sites_factory->SetTestingFactory(&profile_, BuildFakeEmptyTopSites);
- provider_ = ZeroSuggestProvider::Create(this, turl_model, &profile_);
+ provider_ =
+ ZeroSuggestProvider::Create(this, turl_model, &profile_, client_.get());
}
void ZeroSuggestProviderTest::TearDown() {

Powered by Google App Engine
This is Rietveld 408576698