scripts/slave/recipe_modules/chromium_tests/test_api.py - Issue 1185693002: Move builders.py and steps.py to chromium_tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_tests/test_api.py

Issue 1185693002: Move builders.py and steps.py to chromium_tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Address review comments. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/chromium_tests/steps.py ('k') | scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_linux.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/chromium_tests/test_api.py

diff --git a/scripts/slave/recipe_modules/chromium_tests/test_api.py b/scripts/slave/recipe_modules/chromium_tests/test_api.py

index c5d385e66176a2ea0e6aedd4149884aac4c9e20f..fe5fc632d7d141ff76fccc7ea1aa5b3786f65c46 100644

--- a/scripts/slave/recipe_modules/chromium_tests/test_api.py

+++ b/scripts/slave/recipe_modules/chromium_tests/test_api.py

@@ -4,10 +4,16 @@

from recipe_engine import recipe_test_api

+from . import builders

class ChromiumTestsApi(recipe_test_api.RecipeTestApi):

+ @property

+ def builders(self):

+ return builders.BUILDERS

def platform(self, mastername, buildername):

- bot_config = self.m.chromium.builders[mastername]['builders'][buildername]

+ bot_config = builders.BUILDERS[mastername]['builders'][buildername]

# TODO(phajdan.jr): Get the bitness from actual config for that bot.

return self.m.platform(

bot_config['testing']['platform'],