scripts/slave/recipe_modules/chromium_tests/test_api.py - Issue 1185693002: Move builders.py and steps.py to chromium_tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipe_modules/chromium_tests/test_api.py

Issue 1185693002: Move builders.py and steps.py to chromium_tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Address review comments. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « scripts/slave/recipe_modules/chromium_tests/steps.py ('k') | scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_linux.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from recipe_engine import recipe_test_api	5 from recipe_engine import recipe_test_api

6	6

	7 from . import builders

	8

7	9

8 class ChromiumTestsApi(recipe_test_api.RecipeTestApi):	10 class ChromiumTestsApi(recipe_test_api.RecipeTestApi):

	11 @property

	12 def builders(self):

	13 return builders.BUILDERS

	14

9 def platform(self, mastername, buildername):	15 def platform(self, mastername, buildername):

10 bot_config = self.m.chromium.builders[mastername]['builders'][buildername]	16 bot_config = builders.BUILDERS[mastername]['builders'][buildername]

11 # TODO(phajdan.jr): Get the bitness from actual config for that bot.	17 # TODO(phajdan.jr): Get the bitness from actual config for that bot.

12 return self.m.platform(	18 return self.m.platform(

13 bot_config['testing']['platform'],	19 bot_config['testing']['platform'],

14 bot_config.get(	20 bot_config.get(

15 'chromium_config_kwargs', {}).get('TARGET_BITS', 64))	21 'chromium_config_kwargs', {}).get('TARGET_BITS', 64))

OLD	NEW