Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1185683002: Add <stdarg.h> include required for va_start/va_end in GCC (Closed)

Created:
5 years, 6 months ago by philipj_slow
Modified:
5 years, 6 months ago
Reviewers:
Mike West
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Add <stdarg.h> include required for va_start/va_end in GCC https://codereview.chromium.org/1181713004 removed some base/port.h includes, which in turn includes <stdarg.h>. This include is needed to compile with GCC, at least on some systems. BUG=138542 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197088

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/web/tests/WebFrameTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185683002/1
5 years, 6 months ago (2015-06-12 12:54:20 UTC) #2
philipj_slow
PTAL
5 years, 6 months ago (2015-06-12 12:54:48 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-12 14:11:34 UTC) #6
Mike West
LGTM!
5 years, 6 months ago (2015-06-13 08:06:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185683002/1
5 years, 6 months ago (2015-06-13 14:39:12 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-13 16:00:51 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197088

Powered by Google App Engine
This is Rietveld 408576698