Remove base/port.h includes that are not necessary anymore.

Remove base/port.h includes that are not necessary anymore.

There is almost nothing remaining in port.h, just the API_CALL macro.

Since these files are not using it we can remove this include from them.

BUG=138542
R=thestig@chromium.org,mnissler@chromium.org,dmazzoni@chromium.org,dalecurtis@chromium.org,mattm@chromium.org,zea@chromium.org

Committed: https://crrev.com/487ce6b579a992a370c949a74282bc4d09894e6f
Cr-Commit-Position: refs/heads/master@{#334080}

[tfarina, 2015-06-11 19:25:13]

base -> Lei
chrome -> Mattias
content -> Dominic
media -> Dale
net -> Matt
sync -> Nicolas

[DaleCurtis, 2015-06-11 19:28:48]

media/ lgtm

[Nicolas Zea, 2015-06-11 19:31:02]

sync LGTM

[Lei Zhang, 2015-06-11 19:32:35]

https://codereview.chromium.org/1181713004/diff/1/base/basictypes.h
File base/basictypes.h (left):

https://codereview.chromium.org/1181713004/diff/1/base/basictypes.h#oldcode19
base/basictypes.h:19: #include "base/port.h"  // Types that only need exist on
certain systems.
I think this pulled in build/build_config.h, which many files got for free by
including basictypes.h. By removing this, you get lots of red bots.

[tfarina, 2015-06-11 20:30:07]

https://codereview.chromium.org/1181713004/diff/1/base/basictypes.h
File base/basictypes.h (left):

https://codereview.chromium.org/1181713004/diff/1/base/basictypes.h#oldcode19
base/basictypes.h:19: #include "base/port.h"  // Types that only need exist on
certain systems.
On 2015/06/11 19:32:35, Lei Zhang wrote:
> I think this pulled in build/build_config.h, which many files got for free by
> including basictypes.h. By removing this, you get lots of red bots.

Done.

[Lei Zhang, 2015-06-11 20:36:23]

base/ and chrome/ lgtm

build/build_config.h doesn't need to be in base/basictypes.h, but removing that
may require Herculean effort.

[Mattias Nissler (ping if slow), 2015-06-11 20:42:38]

policy LGTM

[dmazzoni, 2015-06-11 21:31:34]

content/browser/accessibility lgtm

[mattm, 2015-06-11 21:33:32]

net lgtm

[tfarina, 2015-06-11 21:40:08]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-06-11 21:40:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org, zea@chromium.org, mnissler@chromium.org,
thestig@chromium.org, dmazzoni@chromium.org, mattm@chromium.org
Link to the patchset: https://codereview.chromium.org/1181713004/#ps40001
(title: "fix win build")

[commit-bot: I haz the power, 2015-06-11 21:42:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1181713004/40001

[commit-bot: I haz the power, 2015-06-11 23:38:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-11 23:40:32]

Patchset 3 (id:??) landed as
https://crrev.com/487ce6b579a992a370c949a74282bc4d09894e6f
Cr-Commit-Position: refs/heads/master@{#334080}