Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1185553002: ResourceTiming should not depend on Document (Closed)

Created:
5 years, 6 months ago by Kunihiko Sakamoto
Modified:
5 years, 6 months ago
Reviewers:
kinuko, Nate Chapin
CC:
blink-reviews, Yoav Weiss, Nate Chapin, gavinp+loader_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

ResourceTiming should not depend on Document In preparation for enabling Resource Timing in workers, this patch removes Document dependency from PerformanceResourceTiming and PerformanceBase::addResourceTiming. BUG=465641 TEST=no functional change; all existing tests should pass Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197220

Patch Set 1 #

Total comments: 2

Patch Set 2 : const ref #

Patch Set 3 : Remove SecurityOrigin parameter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -48 lines) Patch
M Source/core/loader/FrameFetchContext.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/timing/PerformanceBase.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/timing/PerformanceBase.cpp View 1 2 4 chunks +16 lines, -11 lines 0 comments Download
M Source/core/timing/PerformanceResourceTiming.h View 2 chunks +6 lines, -9 lines 0 comments Download
M Source/core/timing/PerformanceResourceTiming.cpp View 13 chunks +19 lines, -26 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Kunihiko Sakamoto
kinuko@: core/timing japhet@: core/loader PTAL, thanks!
5 years, 6 months ago (2015-06-12 02:22:45 UTC) #2
kinuko
lgtm https://codereview.chromium.org/1185553002/diff/1/Source/core/timing/PerformanceBase.h File Source/core/timing/PerformanceBase.h (right): https://codereview.chromium.org/1185553002/diff/1/Source/core/timing/PerformanceBase.h#newcode80 Source/core/timing/PerformanceBase.h:80: void addResourceTiming(const ResourceTimingInfo&, const SecurityOrigin*); nit: if we ...
5 years, 6 months ago (2015-06-12 05:44:54 UTC) #3
Kunihiko Sakamoto
https://codereview.chromium.org/1185553002/diff/1/Source/core/timing/PerformanceBase.h File Source/core/timing/PerformanceBase.h (right): https://codereview.chromium.org/1185553002/diff/1/Source/core/timing/PerformanceBase.h#newcode80 Source/core/timing/PerformanceBase.h:80: void addResourceTiming(const ResourceTimingInfo&, const SecurityOrigin*); On 2015/06/12 05:44:54, kinuko ...
5 years, 6 months ago (2015-06-12 06:03:21 UTC) #4
Kunihiko Sakamoto
Taking one more step forward, I removed the SecurityOrigin parameter from PerformanceBase::addResourceTiming(). kinuko@: Could you ...
5 years, 6 months ago (2015-06-16 05:56:14 UTC) #6
kinuko
On 2015/06/16 05:56:14, Kunihiko Sakamoto wrote: > Taking one more step forward, I removed the ...
5 years, 6 months ago (2015-06-16 14:54:37 UTC) #7
Nate Chapin
lgtm
5 years, 6 months ago (2015-06-16 17:14:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185553002/60001
5 years, 6 months ago (2015-06-17 00:58:22 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 01:02:08 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197220

Powered by Google App Engine
This is Rietveld 408576698