Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Unified Diff: Source/core/timing/PerformanceResourceTiming.h

Issue 1185553002: ResourceTiming should not depend on Document (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove SecurityOrigin parameter Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/timing/PerformanceBase.cpp ('k') | Source/core/timing/PerformanceResourceTiming.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/timing/PerformanceResourceTiming.h
diff --git a/Source/core/timing/PerformanceResourceTiming.h b/Source/core/timing/PerformanceResourceTiming.h
index b76e5a91c09c20642ebdcd3c9fa5d141f8f3c0b3..66efd50d08de05ee98077e3d676d0c9fedf40d8c 100644
--- a/Source/core/timing/PerformanceResourceTiming.h
+++ b/Source/core/timing/PerformanceResourceTiming.h
@@ -38,21 +38,20 @@
namespace blink {
-class Document;
class ResourceLoadTiming;
class ResourceTimingInfo;
class PerformanceResourceTiming final : public PerformanceEntry {
DEFINE_WRAPPERTYPEINFO();
public:
- static PerformanceResourceTiming* create(const ResourceTimingInfo& info, Document* requestingDocument, double startTime, double lastRedirectEndTime, bool m_allowTimingDetails, bool m_allowRedirectDetails)
+ static PerformanceResourceTiming* create(const ResourceTimingInfo& info, double timeOrigin, double startTime, double lastRedirectEndTime, bool m_allowTimingDetails, bool m_allowRedirectDetails)
{
- return new PerformanceResourceTiming(info, requestingDocument, startTime, lastRedirectEndTime, m_allowTimingDetails, m_allowRedirectDetails);
+ return new PerformanceResourceTiming(info, timeOrigin, startTime, lastRedirectEndTime, m_allowTimingDetails, m_allowRedirectDetails);
}
- static PerformanceResourceTiming* create(const ResourceTimingInfo& info, Document* requestingDocument, double startTime, bool m_allowTimingDetails)
+ static PerformanceResourceTiming* create(const ResourceTimingInfo& info, double timeOrigin, double startTime, bool m_allowTimingDetails)
{
- return new PerformanceResourceTiming(info, requestingDocument, startTime, 0.0, m_allowTimingDetails, false);
+ return new PerformanceResourceTiming(info, timeOrigin, startTime, 0.0, m_allowTimingDetails, false);
}
AtomicString initiatorType() const;
@@ -72,16 +71,14 @@ public:
virtual bool isResource() override { return true; }
- DECLARE_VIRTUAL_TRACE();
-
private:
- PerformanceResourceTiming(const ResourceTimingInfo&, Document* requestingDocument, double startTime, double lastRedirectEndTime, bool m_allowTimingDetails, bool m_allowRedirectDetails);
+ PerformanceResourceTiming(const ResourceTimingInfo&, double timeOrigin, double startTime, double lastRedirectEndTime, bool m_allowTimingDetails, bool m_allowRedirectDetails);
virtual ~PerformanceResourceTiming();
double workerReady() const;
AtomicString m_initiatorType;
- RefPtrWillBeMember<Document> m_requestingDocument;
+ double m_timeOrigin;
RefPtr<ResourceLoadTiming> m_timing;
double m_lastRedirectEndTime;
double m_finishTime;
« no previous file with comments | « Source/core/timing/PerformanceBase.cpp ('k') | Source/core/timing/PerformanceResourceTiming.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698