content/browser/renderer_host/render_view_host_delegate.h - Issue 118553006: Move DidFailProvisionalLoad handling from RenderView(Host) to RenderFrame(Host).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_delegate.h

Issue 118553006: Move DidFailProvisionalLoad handling from RenderView(Host) to RenderFrame(Host). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase on ToT. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_frame_host_manager.cc ('k') | content/browser/renderer_host/render_view_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_delegate.h

diff --git a/content/browser/renderer_host/render_view_host_delegate.h b/content/browser/renderer_host/render_view_host_delegate.h

index 1e105e24b6a49f3e95b199687c5eb0c315d342d2..f3e3c1ebd0c272e04a3c59a19b49408ae1145ef1 100644

--- a/content/browser/renderer_host/render_view_host_delegate.h

+++ b/content/browser/renderer_host/render_view_host_delegate.h

@@ -24,7 +24,6 @@ class GURL;

class SkBitmap;

class WebKeyboardEvent;

struct ViewHostMsg_CreateWindow_Params;

-struct ViewHostMsg_DidFailProvisionalLoadWithError_Params;

struct ViewHostMsg_FrameNavigate_Params;

struct ViewMsg_PostMessage_Params;

struct WebPreferences;

@@ -160,11 +159,6 @@ class CONTENT_EXPORT RenderViewHostDelegate {

const GURL& source_url,

const GURL& target_url) {}

- // A provisional load in the RenderView failed.

- virtual void DidFailProvisionalLoadWithError(

- RenderViewHost* render_view_host,

- const ViewHostMsg_DidFailProvisionalLoadWithError_Params& params) {}

// The RenderView was navigated to a different page.

virtual void DidNavigate(RenderViewHost* render_view_host,

const ViewHostMsg_FrameNavigate_Params& params) {}

« no previous file with comments | « content/browser/frame_host/render_frame_host_manager.cc ('k') | content/browser/renderer_host/render_view_host_impl.h » ('j') | no next file with comments »