src/runtime.h - Issue 118553003: Upgrade Symbol implementation to match current ES6 behavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.h

Issue 118553003: Upgrade Symbol implementation to match current ES6 behavior. (Closed) Base URL: git://github.com/v8/v8.git@bleeding_edge

Patch Set: Allow valueOf()/toString() to be called over Symbol values. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime.h

diff --git a/src/runtime.h b/src/runtime.h

index 61c019c068bf1a4f5e3d62a7c758020ba4670ca7..47147adeab050d718c0a2bb6baa6ea31f0de2e28 100644

--- a/src/runtime.h

+++ b/src/runtime.h

@@ -314,7 +314,8 @@ namespace internal {

/* Harmony symbols */ \

F(CreateSymbol, 1, 1) \

F(CreatePrivateSymbol, 1, 1) \

- F(SymbolName, 1, 1) \

+ F(NewSymbolWrapper, 1, 1) \

rossberg 2014/02/14 10:55:30 Seems like this runtime function has become obsole

sof 2014/02/14 14:20:02 I don't understand; it's called by ToObject() to c

rossberg 2014/02/18 17:05:58 Ah, sorry, I missed that. But can't we use Object(

+ F(SymbolDescription, 1, 1) \

F(SymbolIsPrivate, 1, 1) \

/* Harmony proxies */ \

« no previous file with comments | « src/objects.cc ('k') | src/runtime.cc » ('j') | src/runtime.js » ('J')