src/runtime.cc - Issue 118553003: Upgrade Symbol implementation to match current ES6 behavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 118553003: Upgrade Symbol implementation to match current ES6 behavior. (Closed) Base URL: git://github.com/v8/v8.git@bleeding_edge

Patch Set: Allow valueOf()/toString() to be called over Symbol values. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index 3e8d57d039900ac11fc0311b9a45ba35045f9f43..78ae1e0c84c856f715dc1d0096c69e27987d9d90 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -633,7 +633,14 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_CreatePrivateSymbol) {

}

-RUNTIME_FUNCTION(MaybeObject*, Runtime_SymbolName) {

+RUNTIME_FUNCTION(MaybeObject*, Runtime_NewSymbolWrapper) {

+ ASSERT(args.length() == 1);

+ CONVERT_ARG_CHECKED(Symbol, symbol, 0);

+ return symbol->ToObject(isolate);

+RUNTIME_FUNCTION(MaybeObject*, Runtime_SymbolDescription) {

SealHandleScope shs(isolate);

ASSERT(args.length() == 1);

CONVERT_ARG_CHECKED(Symbol, symbol, 0);