Implemented setting memory limits through WebMediaPlayer interface

Implemented setting memory limits through WebMediaPlayer interface

Depends on
https://codereview.chromium.org/1171263004/
https://codereview.chromium.org/1182183004/

BUG=498482

[servolk, 2015-06-17 00:25:18]

servolk@chromium.org changed reviewers:
+ wolenetz@chromium.org

[ddorwin, 2015-06-17 21:02:26]

ddorwin@chromium.org changed reviewers:
+ ddorwin@chromium.org

[ddorwin, 2015-06-17 21:02:27]

https://codereview.chromium.org/1185453004/diff/40001/content/renderer/media/...
File content/renderer/media/android/webmediaplayer_android.cc (right):

https://codereview.chromium.org/1185453004/diff/40001/content/renderer/media/...
content/renderer/media/android/webmediaplayer_android.cc:765: NOTIMPLEMENTED();
As mentioned in https://codereview.chromium.org/1182183004/, this only makes
sense in the MSE case. Thus, it would make more sense to use an MSE-specific
interface (and avoid all the NOTIMPLEMENTED()/NOTREACHED()/return 0.

Also, should this be NOTREACHED() if we only support this for MSE?

https://codereview.chromium.org/1185453004/diff/40001/media/blink/webmediapla...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/1185453004/diff/40001/media/blink/webmediapla...
media/blink/webmediaplayer_impl.cc:599: if (demuxer_ &&
demuxer_->GetStream(DemuxerStream::AUDIO)) {
Is it possible for these to be called when there is no demuxer_?

[servolk, 2015-06-17 22:20:58]

https://codereview.chromium.org/1185453004/diff/40001/content/renderer/media/...
File content/renderer/media/android/webmediaplayer_android.cc (right):

https://codereview.chromium.org/1185453004/diff/40001/content/renderer/media/...
content/renderer/media/android/webmediaplayer_android.cc:765: NOTIMPLEMENTED();
On 2015/06/17 21:02:27, ddorwin wrote:
> As mentioned in https://codereview.chromium.org/1182183004/, this only makes
> sense in the MSE case. Thus, it would make more sense to use an MSE-specific
> interface (and avoid all the NOTIMPLEMENTED()/NOTREACHED()/return 0.
> 
> Also, should this be NOTREACHED() if we only support this for MSE?

See my comments on other CLs: this could make sense also for other cases (e.g.
direct URL playback through FFmpeg or any other media playback through WMP). I
was hoping to provide a common unified interface for setting memory buffer sizes
for media playback that could be later implemented by other media players
(including WebMediaPlayerMS and for the case of the alternative non-MSE playback
here). It's just that MSE is highest-priority use case and we can live with
others being not implemented for now.

https://codereview.chromium.org/1185453004/diff/40001/media/blink/webmediapla...
File media/blink/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/1185453004/diff/40001/media/blink/webmediapla...
media/blink/webmediaplayer_impl.cc:599: if (demuxer_ &&
demuxer_->GetStream(DemuxerStream::AUDIO)) {
On 2015/06/17 21:02:27, ddorwin wrote:
> Is it possible for these to be called when there is no demuxer_?

There are not yet invoked from anywhere.

[servolk, 2015-06-18 23:41:56]

On 2015/06/17 22:20:58, servolk wrote:
>
https://codereview.chromium.org/1185453004/diff/40001/content/renderer/media/...
> File content/renderer/media/android/webmediaplayer_android.cc (right):
> 
>
https://codereview.chromium.org/1185453004/diff/40001/content/renderer/media/...
> content/renderer/media/android/webmediaplayer_android.cc:765:
NOTIMPLEMENTED();
> On 2015/06/17 21:02:27, ddorwin wrote:
> > As mentioned in https://codereview.chromium.org/1182183004/, this only makes
> > sense in the MSE case. Thus, it would make more sense to use an MSE-specific
> > interface (and avoid all the NOTIMPLEMENTED()/NOTREACHED()/return 0.
> > 
> > Also, should this be NOTREACHED() if we only support this for MSE?
> 
> See my comments on other CLs: this could make sense also for other cases (e.g.
> direct URL playback through FFmpeg or any other media playback through WMP). I
> was hoping to provide a common unified interface for setting memory buffer
sizes
> for media playback that could be later implemented by other media players
> (including WebMediaPlayerMS and for the case of the alternative non-MSE
playback
> here). It's just that MSE is highest-priority use case and we can live with
> others being not implemented for now.
> 
>
https://codereview.chromium.org/1185453004/diff/40001/media/blink/webmediapla...
> File media/blink/webmediaplayer_impl.cc (right):
> 
>
https://codereview.chromium.org/1185453004/diff/40001/media/blink/webmediapla...
> media/blink/webmediaplayer_impl.cc:599: if (demuxer_ &&
> demuxer_->GetStream(DemuxerStream::AUDIO)) {
> On 2015/06/17 21:02:27, ddorwin wrote:
> > Is it possible for these to be called when there is no demuxer_?
> 
> There are not yet invoked from anywhere.

FYI: I've merged this CL into https://codereview.chromium.org/1171263004/, since
this CL depends on that one and having a single CL might make code review a bit
easier by removing the need to cross-reference CLs. But if you'd prefer to keep
it separate, please let me know, I can revert the merge and go back to two
separate CLs.