Implemented setting memory limits through WebMediaPlayer interface

content/renderer/media/android/webmediaplayer_android.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/android/webmediaplayer_android.h"
 
 #include <limits>
 
 #include "base/android/build_info.h"
 #include "base/bind.h"
@@ skipping 741 matching lines @@
   return 0;
 }
 
 unsigned WebMediaPlayerAndroid::videoDecodedByteCount() const {
   if (media_source_delegate_)
     return media_source_delegate_->VideoDecodedByteCount();
   NOTIMPLEMENTED();
   return 0;
 }
 
+size_t WebMediaPlayerAndroid::getAudioBufferSize() const {
+  if (media_source_delegate_)
+    return media_source_delegate_->getAudioBufferSize();
+  NOTIMPLEMENTED();

[ddorwin, 2015/06/17 21:02:27]

As mentioned in https://codereview.chromium.org/1182183004/, this only makes
sense in the MSE case. Thus, it would make more sense to use an MSE-specific
interface (and avoid all the NOTIMPLEMENTED()/NOTREACHED()/return 0.

Also, should this be NOTREACHED() if we only support this for MSE?

[servolk, 2015/06/17 22:20:58]

See my comments on other CLs: this could make sense also for other cases (e.g.
direct URL playback through FFmpeg or any other media playback through WMP). I
was hoping to provide a common unified interface for setting memory buffer sizes
for media playback that could be later implemented by other media players
(including WebMediaPlayerMS and for the case of the alternative non-MSE playback
here). It's just that MSE is highest-priority use case and we can live with
others being not implemented for now.

+  return 0;
+}
+
+void WebMediaPlayerAndroid::setAudioBufferSize(size_t size) {
+  if (media_source_delegate_)
+    media_source_delegate_->setAudioBufferSize(size);
+  else
+    NOTIMPLEMENTED();
+}
+
+size_t WebMediaPlayerAndroid::getVideoBufferSize() const {
+  if (media_source_delegate_)
+    return media_source_delegate_->getVideoBufferSize();
+  NOTIMPLEMENTED();
+  return 0;
+}
+
+void WebMediaPlayerAndroid::setVideoBufferSize(size_t size) {
+  if (media_source_delegate_)
+    media_source_delegate_->setVideoBufferSize(size);
+  else
+    NOTIMPLEMENTED();
+}
+
 void WebMediaPlayerAndroid::OnMediaMetadataChanged(
     const base::TimeDelta& duration, int width, int height, bool success) {
   DCHECK(main_thread_checker_.CalledOnValidThread());
   bool need_to_signal_duration_changed = false;
 
   if (is_local_resource_)
     UpdateNetworkState(WebMediaPlayer::NetworkStateLoaded);
 
   // Update duration, if necessary, prior to ready state updates that may
   // cause duration() query.
@@ skipping 1090 matching lines @@
 
 bool WebMediaPlayerAndroid::IsHLSStream() const {
   std::string mime;
   GURL url = redirected_url_.is_empty() ? url_ : redirected_url_;
   if (!net::GetMimeTypeFromFile(base::FilePath(url.path()), &mime))
     return false;
   return !mime.compare("application/x-mpegurl");
 }
 
 }  // namespace content