extensions/renderer/module_system_test.cc - Issue 1185443004: extensions: Use V8 Maybe APIs in ModuleSystem

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/module_system_test.cc

Issue 1185443004: extensions: Use V8 Maybe APIs in ModuleSystem (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add include Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/module_system_test.cc

diff --git a/extensions/renderer/module_system_test.cc b/extensions/renderer/module_system_test.cc

index 04de2b1a45ec5219b7ef52207365aa31b4b64750..72a14727c713b3bba21c7f2d40f1f20f20d85cb6 100644

--- a/extensions/renderer/module_system_test.cc

+++ b/extensions/renderer/module_system_test.cc

@@ -27,6 +27,7 @@ namespace {

class FailsOnException : public ModuleSystem::ExceptionHandler {

public:

+ FailsOnException() : ModuleSystem::ExceptionHandler(NULL) {}

not at google - send to devlin 2015/06/12 16:51:37 nullptr. In fact you might as well s/NULL/nullptr/

bashi 2015/06/16 03:12:47 Done.

void HandleUncaughtException(const v8::TryCatch& try_catch) override {

FAIL() << "Uncaught exception: " << CreateExceptionString(try_catch);

}