Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: extensions/renderer/module_system_test.cc

Issue 1185443004: extensions: Use V8 Maybe APIs in ModuleSystem (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add include Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/renderer/module_system_test.h" 5 #include "extensions/renderer/module_system_test.h"
6 6
7 #include <map> 7 #include <map>
8 #include <string> 8 #include <string>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
11 #include "base/files/file_path.h" 11 #include "base/files/file_path.h"
12 #include "base/files/file_util.h" 12 #include "base/files/file_util.h"
13 #include "base/lazy_instance.h" 13 #include "base/lazy_instance.h"
14 #include "base/memory/scoped_ptr.h" 14 #include "base/memory/scoped_ptr.h"
15 #include "base/path_service.h" 15 #include "base/path_service.h"
16 #include "base/stl_util.h" 16 #include "base/stl_util.h"
17 #include "base/strings/string_piece.h" 17 #include "base/strings/string_piece.h"
18 #include "extensions/common/extension_paths.h" 18 #include "extensions/common/extension_paths.h"
19 #include "extensions/renderer/logging_native_handler.h" 19 #include "extensions/renderer/logging_native_handler.h"
20 #include "extensions/renderer/object_backed_native_handler.h" 20 #include "extensions/renderer/object_backed_native_handler.h"
21 #include "extensions/renderer/safe_builtins.h" 21 #include "extensions/renderer/safe_builtins.h"
22 #include "extensions/renderer/utils_native_handler.h" 22 #include "extensions/renderer/utils_native_handler.h"
23 #include "ui/base/resource/resource_bundle.h" 23 #include "ui/base/resource/resource_bundle.h"
24 24
25 namespace extensions { 25 namespace extensions {
26 namespace { 26 namespace {
27 27
28 class FailsOnException : public ModuleSystem::ExceptionHandler { 28 class FailsOnException : public ModuleSystem::ExceptionHandler {
29 public: 29 public:
30 FailsOnException() : ModuleSystem::ExceptionHandler(NULL) {}
not at google - send to devlin 2015/06/12 16:51:37 nullptr. In fact you might as well s/NULL/nullptr/
bashi 2015/06/16 03:12:47 Done.
30 void HandleUncaughtException(const v8::TryCatch& try_catch) override { 31 void HandleUncaughtException(const v8::TryCatch& try_catch) override {
31 FAIL() << "Uncaught exception: " << CreateExceptionString(try_catch); 32 FAIL() << "Uncaught exception: " << CreateExceptionString(try_catch);
32 } 33 }
33 }; 34 };
34 35
35 class V8ExtensionConfigurator { 36 class V8ExtensionConfigurator {
36 public: 37 public:
37 V8ExtensionConfigurator() 38 V8ExtensionConfigurator()
38 : safe_builtins_(SafeBuiltins::CreateV8Extension()), 39 : safe_builtins_(SafeBuiltins::CreateV8Extension()),
39 names_(1, safe_builtins_->name()), 40 names_(1, safe_builtins_->name()),
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 248
248 void ModuleSystemTest::ExpectNoAssertionsMade() { 249 void ModuleSystemTest::ExpectNoAssertionsMade() {
249 should_assertions_be_made_ = false; 250 should_assertions_be_made_ = false;
250 } 251 }
251 252
252 void ModuleSystemTest::RunResolvedPromises() { 253 void ModuleSystemTest::RunResolvedPromises() {
253 isolate_->RunMicrotasks(); 254 isolate_->RunMicrotasks();
254 } 255 }
255 256
256 } // namespace extensions 257 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698