extensions: Use V8 Maybe APIs in ModuleSystem

extensions/renderer/module_system.h

Index: extensions/renderer/module_system.h
diff --git a/extensions/renderer/module_system.h b/extensions/renderer/module_system.h
index 82474b6463c04a0d8874612f35ffeab3dfee2acb..7370f959ee481e9b9099e65561f2709bcd08094e 100644
--- a/extensions/renderer/module_system.h
+++ b/extensions/renderer/module_system.h
@@ -51,10 +51,12 @@ class ModuleSystem : public ObjectBackedNativeHandler,
 
   class ExceptionHandler {
    public:
+    ExceptionHandler(ScriptContext* context) : context_(context) {}

[not at google - send to devlin, 2015/06/12 16:51:37]

explicit

[bashi, 2015/06/16 03:12:47]

Done.

     virtual ~ExceptionHandler() {}
     virtual void HandleUncaughtException(const v8::TryCatch& try_catch) = 0;
 
    protected:
+    ScriptContext* context_;

[not at google - send to devlin, 2015/06/12 16:51:36]

Declare member variables after methods, and comment what the lifetime
relationship is between it and its owner.

[bashi, 2015/06/16 03:12:47]

Done.

     // Formats |try_catch| as a nice string.
     std::string CreateExceptionString(const v8::TryCatch& try_catch);
   };
@@ -126,7 +128,7 @@ class ModuleSystem : public ObjectBackedNativeHandler,
                     const std::string& field,
                     const std::string& module_name,
                     const std::string& module_field,
-                    v8::AccessorGetterCallback getter);
+                    v8::AccessorNameGetterCallback getter);
 
   // Make |object|.|field| lazily evaluate to the result of
   // requireNative(|module_name|)[|module_field|].
@@ -150,12 +152,12 @@ class ModuleSystem : public ObjectBackedNativeHandler,
   typedef std::map<std::string, linked_ptr<NativeHandler> > NativeHandlerMap;
 
   // Retrieves the lazily defined field specified by |property|.
-  static void LazyFieldGetter(v8::Local<v8::String> property,
+  static void LazyFieldGetter(v8::Local<v8::Name> property,

[not at google - send to devlin, 2015/06/12 16:51:36]

Quick question: should these have been "const Local<Name>&" rather than
"Local<Name>"? I can fix it up later if so, I'm just curious.

[bashi, 2015/06/16 03:12:47]

IIUC, V8 handles are passed by values so it should be "v8::Local<v8::Name>".

                               const v8::PropertyCallbackInfo<v8::Value>& info);
   // Retrieves the lazily defined field specified by |property| on a native
   // object.
   static void NativeLazyFieldGetter(
-      v8::Local<v8::String> property,
+      v8::Local<v8::Name> property,
       const v8::PropertyCallbackInfo<v8::Value>& info);
 
   // Called when an exception is thrown but not caught.