extensions: Use V8 Maybe APIs in ModuleSystem

extensions/renderer/module_system.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_RENDERER_MODULE_SYSTEM_H_
 #define EXTENSIONS_RENDERER_MODULE_SYSTEM_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 33 matching lines @@
   class SourceMap {
    public:
     virtual ~SourceMap() {}
     virtual v8::Local<v8::Value> GetSource(v8::Isolate* isolate,
                                            const std::string& name) = 0;
     virtual bool Contains(const std::string& name) = 0;
   };
 
   class ExceptionHandler {
    public:
+    ExceptionHandler(ScriptContext* context) : context_(context) {}

[not at google - send to devlin, 2015/06/12 16:51:37]

explicit

[bashi, 2015/06/16 03:12:47]

Done.

     virtual ~ExceptionHandler() {}
     virtual void HandleUncaughtException(const v8::TryCatch& try_catch) = 0;
 
    protected:
+    ScriptContext* context_;

[not at google - send to devlin, 2015/06/12 16:51:36]

Declare member variables after methods, and comment what the lifetime
relationship is between it and its owner.

[bashi, 2015/06/16 03:12:47]

Done.

     // Formats |try_catch| as a nice string.
     std::string CreateExceptionString(const v8::TryCatch& try_catch);
   };
 
   // Enables native bindings for the duration of its lifetime.
   class NativesEnabledScope {
    public:
     explicit NativesEnabledScope(ModuleSystem* module_system);
     ~NativesEnabledScope();
 
@@ skipping 51 matching lines @@
   //               object is the only client, only that needs to implement it).
   void SetLazyField(v8::Local<v8::Object> object,
                     const std::string& field,
                     const std::string& module_name,
                     const std::string& module_field);
 
   void SetLazyField(v8::Local<v8::Object> object,
                     const std::string& field,
                     const std::string& module_name,
                     const std::string& module_field,
-                    v8::AccessorGetterCallback getter);
+                    v8::AccessorNameGetterCallback getter);
 
   // Make |object|.|field| lazily evaluate to the result of
   // requireNative(|module_name|)[|module_field|].
   // TODO(kalman): Same as above.
   void SetNativeLazyField(v8::Local<v8::Object> object,
                           const std::string& field,
                           const std::string& module_name,
                           const std::string& module_field);
 
   // Passes exceptions to |handler| rather than console::Fatal.
   void SetExceptionHandlerForTest(scoped_ptr<ExceptionHandler> handler) {
     exception_handler_ = handler.Pass();
   }
 
  protected:
   friend class ModuleSystemTestEnvironment;
   friend class ScriptContext;
   void Invalidate() override;
 
  private:
   typedef std::map<std::string, linked_ptr<NativeHandler> > NativeHandlerMap;
 
   // Retrieves the lazily defined field specified by |property|.
-  static void LazyFieldGetter(v8::Local<v8::String> property,
+  static void LazyFieldGetter(v8::Local<v8::Name> property,

[not at google - send to devlin, 2015/06/12 16:51:36]

Quick question: should these have been "const Local<Name>&" rather than
"Local<Name>"? I can fix it up later if so, I'm just curious.

[bashi, 2015/06/16 03:12:47]

IIUC, V8 handles are passed by values so it should be "v8::Local<v8::Name>".

                               const v8::PropertyCallbackInfo<v8::Value>& info);
   // Retrieves the lazily defined field specified by |property| on a native
   // object.
   static void NativeLazyFieldGetter(
-      v8::Local<v8::String> property,
+      v8::Local<v8::Name> property,
       const v8::PropertyCallbackInfo<v8::Value>& info);
 
   // Called when an exception is thrown but not caught.
   void HandleException(const v8::TryCatch& try_catch);
 
   void RequireForJs(const v8::FunctionCallbackInfo<v8::Value>& args);
   v8::Local<v8::Value> RequireForJsInner(v8::Local<v8::String> module_name);
 
   typedef v8::Local<v8::Value>(ModuleSystem::*RequireFunction)(
       const std::string&);
@@ skipping 69 matching lines @@
   std::vector<linked_ptr<NativeHandler>> clobbered_native_handlers_;
 
   base::WeakPtrFactory<ModuleSystem> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ModuleSystem);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_RENDERER_MODULE_SYSTEM_H_