|
Revert of Revert of [strong] Implement strong mode restrictions on property access (patchset #1 id:1 of https://codereview.chromium.org/1189153002/)
Reason for revert:
Issue was ultimately caused/fixed by https://codereview.chromium.org/1194673002/
Original issue's description:
> Revert of [strong] Implement strong mode restrictions on property access (patchset #23 id:460001 of https://codereview.chromium.org/1168093002/)
>
> Reason for revert:
> Speculative revert, maybe breaks GC-stress
>
> http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/808
>
> Original issue's description:
> > [strong] Implement strong mode restrictions on property access
> >
> > Implements the strong mode proposal's restrictions on property access.
> >
> > To be fully explored in a followup: proxies, interceptors, access checks, load from super
> >
> > BUG= v8:3956
> > LOG=N
> >
> > Committed: https://crrev.com/85dbfb9a389e7b21bd2a63862202ee97fc5d7982
> > Cr-Commit-Position: refs/heads/master@{#29109}
>
> TBR=rossberg@chromium.org,mvstanton@chromium.org,mstarzinger@chromium.org,verwaest@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= v8:3956
>
> Committed: https://crrev.com/407657b706711fd5f8d417841e24b284886f3776
> Cr-Commit-Position: refs/heads/master@{#29115}
TBR=rossberg@chromium.org,mvstanton@chromium.org,mstarzinger@chromium.org,verwaest@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= v8:3956
LOG=N
Committed: https://crrev.com/41405c0470d5b30ec5d22665ed9430c46b33624f
Cr-Commit-Position: refs/heads/master@{#29122}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+2423 lines, -884 lines) |
Patch |
|
M |
src/arm/code-stubs-arm.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/arm/full-codegen-arm.cc
|
View
|
|
8 chunks |
+13 lines, -7 lines |
0 comments
|
Download
|
|
M |
src/arm/lithium-codegen-arm.cc
|
View
|
|
3 chunks |
+8 lines, -7 lines |
0 comments
|
Download
|
|
M |
src/arm64/code-stubs-arm64.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/arm64/full-codegen-arm64.cc
|
View
|
|
7 chunks |
+13 lines, -8 lines |
0 comments
|
Download
|
|
M |
src/arm64/lithium-codegen-arm64.cc
|
View
|
|
3 chunks |
+8 lines, -8 lines |
0 comments
|
Download
|
|
M |
src/builtins.h
|
View
|
|
3 chunks |
+10 lines, -9 lines |
0 comments
|
Download
|
|
M |
src/builtins.cc
|
View
|
|
2 chunks |
+8 lines, -8 lines |
0 comments
|
Download
|
|
M |
src/code-factory.h
|
View
|
|
1 chunk |
+6 lines, -3 lines |
0 comments
|
Download
|
|
M |
src/code-factory.cc
|
View
|
|
1 chunk |
+17 lines, -8 lines |
0 comments
|
Download
|
|
M |
src/code-stubs.h
|
View
|
|
5 chunks |
+29 lines, -7 lines |
0 comments
|
Download
|
|
M |
src/code-stubs.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
src/code-stubs-hydrogen.cc
|
View
|
|
6 chunks |
+10 lines, -11 lines |
0 comments
|
Download
|
|
M |
src/compiler/ast-graph-builder.cc
|
View
|
|
4 chunks |
+9 lines, -7 lines |
0 comments
|
Download
|
|
M |
src/compiler/js-generic-lowering.cc
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
src/compiler/js-operator.h
|
View
|
|
4 chunks |
+16 lines, -4 lines |
0 comments
|
Download
|
|
M |
src/compiler/js-operator.cc
|
View
|
|
5 chunks |
+14 lines, -10 lines |
0 comments
|
Download
|
|
M |
src/compiler/js-typed-lowering.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/full-codegen.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
src/full-codegen.cc
|
View
|
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
src/hydrogen.h
|
View
|
|
2 chunks |
+4 lines, -3 lines |
0 comments
|
Download
|
|
M |
src/hydrogen.cc
|
View
|
|
7 chunks |
+19 lines, -15 lines |
0 comments
|
Download
|
|
M |
src/hydrogen-instructions.h
|
View
|
|
6 chunks |
+17 lines, -5 lines |
0 comments
|
Download
|
|
M |
src/ia32/code-stubs-ia32.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/ia32/full-codegen-ia32.cc
|
View
|
|
6 chunks |
+13 lines, -7 lines |
0 comments
|
Download
|
|
M |
src/ia32/lithium-codegen-ia32.cc
|
View
|
|
3 chunks |
+8 lines, -7 lines |
0 comments
|
Download
|
|
M |
src/ic/arm/handler-compiler-arm.cc
|
View
|
|
1 chunk |
+24 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/ic/arm/ic-arm.cc
|
View
|
|
9 chunks |
+33 lines, -17 lines |
0 comments
|
Download
|
|
M |
src/ic/arm64/handler-compiler-arm64.cc
|
View
|
|
1 chunk |
+24 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/ic/arm64/ic-arm64.cc
|
View
|
|
10 chunks |
+35 lines, -16 lines |
0 comments
|
Download
|
|
M |
src/ic/handler-compiler.h
|
View
|
|
2 chunks |
+6 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/ic/handler-compiler.cc
|
View
|
|
3 chunks |
+9 lines, -4 lines |
0 comments
|
Download
|
|
M |
src/ic/ia32/handler-compiler-ia32.cc
|
View
|
|
1 chunk |
+33 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/ic/ia32/ic-ia32.cc
|
View
|
|
12 chunks |
+27 lines, -14 lines |
0 comments
|
Download
|
|
M |
src/ic/ic.h
|
View
|
|
6 chunks |
+21 lines, -10 lines |
0 comments
|
Download
|
|
M |
src/ic/ic.cc
|
View
|
|
15 chunks |
+72 lines, -32 lines |
0 comments
|
Download
|
|
M |
src/ic/ic-compiler.h
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/ic/ic-compiler.cc
|
View
|
|
5 chunks |
+7 lines, -6 lines |
0 comments
|
Download
|
|
M |
src/ic/ic-inl.h
|
View
|
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/ic/ic-state.h
|
View
|
|
2 chunks |
+20 lines, -8 lines |
0 comments
|
Download
|
|
M |
src/ic/mips/handler-compiler-mips.cc
|
View
|
|
1 chunk |
+24 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/ic/mips/ic-mips.cc
|
View
|
|
9 chunks |
+31 lines, -17 lines |
0 comments
|
Download
|
|
M |
src/ic/mips64/handler-compiler-mips64.cc
|
View
|
|
1 chunk |
+24 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/ic/mips64/ic-mips64.cc
|
View
|
|
10 chunks |
+19 lines, -12 lines |
0 comments
|
Download
|
|
M |
src/ic/ppc/handler-compiler-ppc.cc
|
View
|
|
1 chunk |
+24 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/ic/ppc/ic-ppc.cc
|
View
|
|
9 chunks |
+31 lines, -17 lines |
0 comments
|
Download
|
|
M |
src/ic/x64/handler-compiler-x64.cc
|
View
|
|
1 chunk |
+33 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/ic/x64/ic-x64.cc
|
View
|
|
12 chunks |
+27 lines, -14 lines |
0 comments
|
Download
|
|
M |
src/ic/x87/handler-compiler-x87.cc
|
View
|
|
1 chunk |
+33 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/ic/x87/ic-x87.cc
|
View
|
|
12 chunks |
+27 lines, -14 lines |
0 comments
|
Download
|
|
M |
src/messages.h
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/mips/code-stubs-mips.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/mips/full-codegen-mips.cc
|
View
|
|
8 chunks |
+13 lines, -7 lines |
0 comments
|
Download
|
|
M |
src/mips/lithium-codegen-mips.cc
|
View
|
|
3 chunks |
+8 lines, -7 lines |
0 comments
|
Download
|
|
M |
src/mips64/code-stubs-mips64.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/mips64/full-codegen-mips64.cc
|
View
|
|
8 chunks |
+13 lines, -7 lines |
0 comments
|
Download
|
|
M |
src/mips64/lithium-codegen-mips64.cc
|
View
|
|
3 chunks |
+8 lines, -7 lines |
0 comments
|
Download
|
|
M |
src/objects.h
|
View
|
|
5 chunks |
+18 lines, -12 lines |
0 comments
|
Download
|
|
M |
src/objects.cc
|
View
|
|
7 chunks |
+32 lines, -10 lines |
0 comments
|
Download
|
|
M |
src/objects-inl.h
|
View
|
|
3 chunks |
+17 lines, -15 lines |
0 comments
|
Download
|
|
M |
src/ppc/code-stubs-ppc.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/ppc/full-codegen-ppc.cc
|
View
|
|
8 chunks |
+13 lines, -7 lines |
0 comments
|
Download
|
|
M |
src/ppc/lithium-codegen-ppc.cc
|
View
|
|
3 chunks |
+8 lines, -7 lines |
0 comments
|
Download
|
|
M |
src/runtime/runtime.h
|
View
|
|
3 chunks |
+12 lines, -6 lines |
0 comments
|
Download
|
|
M |
src/runtime/runtime-classes.cc
|
View
|
|
3 chunks |
+62 lines, -32 lines |
0 comments
|
Download
|
|
M |
src/runtime/runtime-debug.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
src/runtime/runtime-object.cc
|
View
|
|
10 chunks |
+346 lines, -333 lines |
0 comments
|
Download
|
|
M |
src/x64/code-stubs-x64.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/x64/full-codegen-x64.cc
|
View
|
|
8 chunks |
+13 lines, -7 lines |
0 comments
|
Download
|
|
M |
src/x64/lithium-codegen-x64.cc
|
View
|
|
3 chunks |
+8 lines, -7 lines |
0 comments
|
Download
|
|
M |
src/x87/code-stubs-x87.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/x87/full-codegen-x87.cc
|
View
|
|
6 chunks |
+13 lines, -7 lines |
0 comments
|
Download
|
|
M |
src/x87/lithium-codegen-x87.cc
|
View
|
|
3 chunks |
+8 lines, -6 lines |
0 comments
|
Download
|
|
M |
test/cctest/test-api.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
test/mjsunit/strong/functions.js
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
A |
test/mjsunit/strong/load-builtins.js
|
View
|
|
1 chunk |
+42 lines, -0 lines |
0 comments
|
Download
|
|
A |
test/mjsunit/strong/load-element.js
|
View
|
|
1 chunk |
+264 lines, -0 lines |
0 comments
|
Download
|
|
A |
test/mjsunit/strong/load-element-mutate-backing-store.js
|
View
|
|
1 chunk |
+239 lines, -0 lines |
0 comments
|
Download
|
|
A |
test/mjsunit/strong/load-property.js
|
View
|
|
1 chunk |
+200 lines, -0 lines |
0 comments
|
Download
|
|
A |
test/mjsunit/strong/load-property-mutate-backing-store.js
|
View
|
|
1 chunk |
+174 lines, -0 lines |
0 comments
|
Download
|
|
M |
test/unittests/compiler/js-type-feedback-unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
test/unittests/compiler/js-typed-lowering-unittest.cc
|
View
|
|
3 chunks |
+68 lines, -59 lines |
0 comments
|
Download
|
Total messages: 6 (1 generated)
|