Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: src/code-factory.cc

Issue 1185343005: Revert of Revert of [strong] Implement strong mode restrictions on property access (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-factory.h ('k') | src/code-stubs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-factory.cc
diff --git a/src/code-factory.cc b/src/code-factory.cc
index fc7ea4aa3625c5491eb9e4fd0562c2ba2887353d..89977470057115a4e7ae700c75efce3d813714fb 100644
--- a/src/code-factory.cc
+++ b/src/code-factory.cc
@@ -13,35 +13,44 @@
// static
-Callable CodeFactory::LoadIC(Isolate* isolate, ContextualMode mode) {
+Callable CodeFactory::LoadIC(Isolate* isolate, ContextualMode mode,
+ LanguageMode language_mode) {
return Callable(
- LoadIC::initialize_stub(isolate, LoadICState(mode).GetExtraICState()),
+ LoadIC::initialize_stub(
+ isolate, LoadICState(mode, language_mode).GetExtraICState()),
LoadDescriptor(isolate));
}
// static
Callable CodeFactory::LoadICInOptimizedCode(
- Isolate* isolate, ContextualMode mode,
+ Isolate* isolate, ContextualMode mode, LanguageMode language_mode,
InlineCacheState initialization_state) {
auto code = LoadIC::initialize_stub_in_optimized_code(
- isolate, LoadICState(mode).GetExtraICState(), initialization_state);
+ isolate, LoadICState(mode, language_mode).GetExtraICState(),
+ initialization_state);
return Callable(code, LoadWithVectorDescriptor(isolate));
}
// static
-Callable CodeFactory::KeyedLoadIC(Isolate* isolate) {
- return Callable(KeyedLoadIC::initialize_stub(isolate),
+Callable CodeFactory::KeyedLoadIC(Isolate* isolate,
+ LanguageMode language_mode) {
+ ExtraICState state =
+ is_strong(language_mode) ? LoadICState::kStrongModeState : 0;
+ return Callable(KeyedLoadIC::initialize_stub(isolate, state),
LoadDescriptor(isolate));
}
// static
Callable CodeFactory::KeyedLoadICInOptimizedCode(
- Isolate* isolate, InlineCacheState initialization_state) {
+ Isolate* isolate, LanguageMode language_mode,
+ InlineCacheState initialization_state) {
+ ExtraICState state =
+ is_strong(language_mode) ? LoadICState::kStrongModeState : 0;
auto code = KeyedLoadIC::initialize_stub_in_optimized_code(
- isolate, initialization_state);
+ isolate, initialization_state, state);
if (initialization_state != MEGAMORPHIC) {
return Callable(code, LoadWithVectorDescriptor(isolate));
}
« no previous file with comments | « src/code-factory.h ('k') | src/code-stubs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698