Source/modules/accessibility/AXInlineTextBox.h - Issue 1185343003: Implements the ability to get and set the caret position and the current selection from anywhere in…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXInlineTextBox.h

Issue 1185343003: Implements the ability to get and set the caret position and the current selection from anywhere in… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed more comments from reviewer. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/accessibility/contenteditable-caret-position.html ('k') | Source/modules/accessibility/AXInlineTextBox.cpp » ('j') | Source/modules/accessibility/AXLayoutObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/accessibility/AXInlineTextBox.h

diff --git a/Source/modules/accessibility/AXInlineTextBox.h b/Source/modules/accessibility/AXInlineTextBox.h

index cdbcd7e9edd39ebeaab60910428cd23bd1a39337..55ec98a386c177108213060693a8c70366ee0dab 100644

--- a/Source/modules/accessibility/AXInlineTextBox.h

+++ b/Source/modules/accessibility/AXInlineTextBox.h

@@ -53,7 +53,7 @@ public:

virtual AccessibilityRole roleValue() const override { return InlineTextBoxRole; }

virtual String stringValue() const override;

virtual void textCharacterOffsets(Vector<int>&) const override;

- virtual void wordBoundaries(Vector<PlainTextRange>& words) const override;

+ virtual void wordBoundaries(Vector<AXRange>& words) const override;

virtual LayoutRect elementRect() const override;

virtual AXObject* computeParent() const override;

virtual AccessibilityTextDirection textDirection() const override;