Source/modules/accessibility/AXInlineTextBox.cpp - Issue 1185343003: Implements the ability to get and set the caret position and the current selection from anywhere in…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXInlineTextBox.cpp

Issue 1185343003: Implements the ability to get and set the caret position and the current selection from anywhere in… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed more comments from reviewer. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/accessibility/AXInlineTextBox.h ('k') | Source/modules/accessibility/AXLayoutObject.h » ('j') | Source/modules/accessibility/AXLayoutObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/accessibility/AXInlineTextBox.cpp

diff --git a/Source/modules/accessibility/AXInlineTextBox.cpp b/Source/modules/accessibility/AXInlineTextBox.cpp

index f5dc8573b3b8ae3c462e8774b8c1c667091cb537..7dd89d44773bd64e5807280aa5fc24fe86defd98 100644

--- a/Source/modules/accessibility/AXInlineTextBox.cpp

+++ b/Source/modules/accessibility/AXInlineTextBox.cpp

@@ -108,7 +108,7 @@ void AXInlineTextBox::textCharacterOffsets(Vector<int>& offsets) const

}

-void AXInlineTextBox::wordBoundaries(Vector<PlainTextRange>& words) const

+void AXInlineTextBox::wordBoundaries(Vector<AXRange>& words) const

{

if (!m_inlineTextBox)

return;

@@ -117,7 +117,7 @@ void AXInlineTextBox::wordBoundaries(Vector<PlainTextRange>& words) const

m_inlineTextBox->wordBoundaries(wordBoundaries);

words.resize(wordBoundaries.size());

for (unsigned i = 0; i < wordBoundaries.size(); i++)

- words[i] = PlainTextRange(wordBoundaries[i].startIndex, wordBoundaries[i].endIndex - wordBoundaries[i].startIndex);

+ words[i] = AXRange(wordBoundaries[i].startIndex, wordBoundaries[i].endIndex);

}

String AXInlineTextBox::stringValue() const