|
|
DescriptionAdd signcla verifier for v8.
Currently this verifier will post an informative error if the author has not signed CLA, instead of rejecting the CL.
LOG=N
BUG=457428
Committed: https://crrev.com/99e24fccf6f765d4646c9150ea4683cdd51df346
Cr-Commit-Position: refs/heads/master@{#29096}
Patch Set 1 #
Messages
Total messages: 19 (6 generated)
sheyang@chromium.org changed reviewers: + machenbach@chromium.org, sergiyb@chromium.org
lgtm
The CQ bit was checked by sheyang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185193009/1
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by sheyang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185193009/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/3486)
On 2015/06/17 16:09:16, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > v8_presubmit on tryserver.v8 (JOB_FAILED, > http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/3486) Sheng, you need to add "LOG=N" into description for V8 CLs. This basically says that you don't want this change to show up in V8 Changelist for the next release (not sure where it appears).
On 2015/06/17 16:11:22, Sergiy Byelozyorov wrote: > On 2015/06/17 16:09:16, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > v8_presubmit on tryserver.v8 (JOB_FAILED, > > http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/3486) > > Sheng, you need to add "LOG=N" into description for V8 CLs. This basically says > that you don't want this change to show up in V8 Changelist for the next release > (not sure where it appears). Thanks for the info. Added.
The CQ bit was checked by sheyang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185193009/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/99e24fccf6f765d4646c9150ea4683cdd51df346 Cr-Commit-Position: refs/heads/master@{#29096}
Message was sent while issue was closed.
On 2015/06/17 at 16:37:04, commit-bot wrote: > Patchset 1 (id:??) landed as https://crrev.com/99e24fccf6f765d4646c9150ea4683cdd51df346 > Cr-Commit-Position: refs/heads/master@{#29096} Since this check-in I got reports from external contributors which companies have signed a corporate CLA that they receive a message like in https://codereview.chromium.org/1038363002. Do you have clue what's wrong here? |