Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 1185193009: Add signcla verifier for v8 (Closed)

Created:
5 years, 6 months ago by sheyang
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add signcla verifier for v8. Currently this verifier will post an informative error if the author has not signed CLA, instead of rejecting the CL. LOG=N BUG=457428 Committed: https://crrev.com/99e24fccf6f765d4646c9150ea4683cdd51df346 Cr-Commit-Position: refs/heads/master@{#29096}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M infra/config/cq.cfg View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
sheyang
5 years, 6 months ago (2015-06-16 18:24:24 UTC) #2
Sergiy Byelozyorov
lgtm
5 years, 6 months ago (2015-06-16 20:12:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185193009/1
5 years, 6 months ago (2015-06-16 20:48:32 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 6 months ago (2015-06-16 20:48:35 UTC) #7
Michael Achenbach
lgtm
5 years, 6 months ago (2015-06-17 06:59:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185193009/1
5 years, 6 months ago (2015-06-17 16:06:16 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/3486)
5 years, 6 months ago (2015-06-17 16:09:16 UTC) #12
Sergiy Byelozyorov
On 2015/06/17 16:09:16, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 6 months ago (2015-06-17 16:11:22 UTC) #13
sheyang
On 2015/06/17 16:11:22, Sergiy Byelozyorov wrote: > On 2015/06/17 16:09:16, commit-bot: I haz the power ...
5 years, 6 months ago (2015-06-17 16:22:18 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185193009/1
5 years, 6 months ago (2015-06-17 16:22:32 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 16:36:45 UTC) #17
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/99e24fccf6f765d4646c9150ea4683cdd51df346 Cr-Commit-Position: refs/heads/master@{#29096}
5 years, 6 months ago (2015-06-17 16:37:04 UTC) #18
Michael Hablich
5 years, 5 months ago (2015-07-13 09:43:13 UTC) #19
Message was sent while issue was closed.
On 2015/06/17 at 16:37:04, commit-bot wrote:
> Patchset 1 (id:??) landed as
https://crrev.com/99e24fccf6f765d4646c9150ea4683cdd51df346
> Cr-Commit-Position: refs/heads/master@{#29096}

Since this check-in I got reports from external contributors which companies
have signed a corporate CLA that they receive a message like in
https://codereview.chromium.org/1038363002. Do you have clue what's wrong here?

Powered by Google App Engine
This is Rietveld 408576698