Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1038363002: Reland r21101: "ARM64: use jssp for stack slots" (Closed)

Created:
5 years, 9 months ago by jbramley
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland r21101: "ARM64: use jssp for stack slots" The original implementation assumed that LPushArguments and LInvoke/Call* could be assumed to be exclusively sequential. However, this isn't always the case. For example, GenerateCallFunction pushes some arguments and then selects between HInvokeFunction and HCallFunction. This fixed implementation resets a pushed_arguments_ counter based on the argument_count() of the preceeding basic block, then tracks it per-instruction as before (except that now we maintain a count rather than a boolean flag). At the same time, since we now track exactly how many arguments have been pushed onto the stack, I was able to adjust the offset accordingly and use jssp for stack slots even when arguments have been pushed. BUG= Committed: https://crrev.com/48d726cd6f6ad176d54b546b7d1ca717e5478b46 Cr-Commit-Position: refs/heads/master@{#29249}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -5 lines) Patch
M src/arm64/lithium-codegen-arm64.h View 1 3 chunks +14 lines, -2 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 11 chunks +48 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
jbramley
5 years, 9 months ago (2015-03-27 10:46:17 UTC) #2
jbramley
Could someone have a look please?
5 years, 6 months ago (2015-05-29 12:35:21 UTC) #3
Benedikt Meurer
LGTM. Sorry for the delay.
5 years, 6 months ago (2015-06-24 06:20:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1038363002/20001
5 years, 6 months ago (2015-06-24 06:20:26 UTC) #7
commit-bot: I haz the power
The author jacob.bramley@arm.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 6 months ago (2015-06-24 06:20:27 UTC) #8
commit-bot: I haz the power
The author jacob.bramley@arm.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 6 months ago (2015-06-24 06:30:42 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-24 06:47:32 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 06:47:54 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/48d726cd6f6ad176d54b546b7d1ca717e5478b46
Cr-Commit-Position: refs/heads/master@{#29249}

Powered by Google App Engine
This is Rietveld 408576698