Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart

Issue 1184963006: dart2js cps: Better 'is int' checks. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Update comment Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_backend/codegen/codegen.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart
diff --git a/pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart b/pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart
index 189171739d1a263dcc06ce072051579a34aa3157..65ca23aeb925804c417b44290dadc9c688b3fa19 100644
--- a/pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart
+++ b/pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart
@@ -248,6 +248,10 @@ class LogicalRewriter extends RecursiveTransformer
case BuiltinOperator.NumLe:
case BuiltinOperator.NumGt:
case BuiltinOperator.NumGe:
+ case BuiltinOperator.IsNumber:
+ case BuiltinOperator.IsNotNumber:
+ case BuiltinOperator.IsFloor:
+ case BuiltinOperator.IsNumberAndFloor:
return true;
default:
return false;
@@ -260,6 +264,8 @@ class LogicalRewriter extends RecursiveTransformer
case BuiltinOperator.StrictNeq: return BuiltinOperator.StrictEq;
case BuiltinOperator.LooseEq: return BuiltinOperator.LooseNeq;
case BuiltinOperator.LooseNeq: return BuiltinOperator.LooseEq;
+ case BuiltinOperator.IsNumber: return BuiltinOperator.IsNotNumber;
+ case BuiltinOperator.IsNotNumber: return BuiltinOperator.IsNumber;
// Because of NaN, these do not have a negated form.
case BuiltinOperator.NumLt:
« no previous file with comments | « pkg/compiler/lib/src/js_backend/codegen/codegen.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698