Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 1184963006: dart2js cps: Better 'is int' checks. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Update comment Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/codegen/codegen.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
index b752a21a540e29dae94df820edd83dc87ef1e4c7..137b422cafdcfd71574cd01dd0104807885f53e8 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
@@ -707,11 +707,11 @@ class CodeGenerator extends tree_ir.StatementVisitor
case BuiltinOperator.NumMultiply:
return new js.Binary('*', args[0], args[1]);
case BuiltinOperator.NumAnd:
- return js.js('(# & #) >>> 0', <js.Expression>[args[0], args[1]]);
+ return js.js('(# & #) >>> 0', args);
case BuiltinOperator.NumOr:
- return js.js('(# | #) >>> 0', <js.Expression>[args[0], args[1]]);
+ return js.js('(# | #) >>> 0', args);
case BuiltinOperator.NumXor:
- return js.js('(# ^ #) >>> 0', <js.Expression>[args[0], args[1]]);
+ return js.js('(# ^ #) >>> 0', args);
case BuiltinOperator.NumLt:
return new js.Binary('<', args[0], args[1]);
case BuiltinOperator.NumLe:
@@ -730,6 +730,14 @@ class CodeGenerator extends tree_ir.StatementVisitor
return new js.Binary('!=', args[0], args[1]);
case BuiltinOperator.IsFalsy:
return new js.Prefix('!', args[0]);
+ case BuiltinOperator.IsNumber:
+ return js.js("typeof # === 'number'", args);
+ case BuiltinOperator.IsNotNumber:
+ return js.js("typeof # !== 'number'", args);
+ case BuiltinOperator.IsFloor:
+ return js.js("Math.floor(#) === #", args);
+ case BuiltinOperator.IsNumberAndFloor:
+ return js.js("typeof # === 'number' && Math.floor(#) === #", args);
}
}
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/type_propagation.dart ('k') | pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698