Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 1184923003: Skip slow tests in non debug too (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)
Modified:
5 years, 6 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Skip slow tests in non debug too BUG=N LOG=N TBR=adamk Committed: https://crrev.com/17b0f16c760e5b0d51ae87742a864de93b6f4c0b Cr-Commit-Position: refs/heads/master@{#29058}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M test/test262-es6/test262-es6.status View 1 chunk +14 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
arv (Not doing code reviews)
PTAL
5 years, 6 months ago (2015-06-16 23:37:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184923003/1
5 years, 6 months ago (2015-06-16 23:38:21 UTC) #3
adamk
lgtm
5 years, 6 months ago (2015-06-16 23:48:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 00:03:07 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/17b0f16c760e5b0d51ae87742a864de93b6f4c0b Cr-Commit-Position: refs/heads/master@{#29058}
5 years, 6 months ago (2015-06-17 00:03:17 UTC) #6
Michael Achenbach
5 years, 6 months ago (2015-06-17 06:51:22 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1177223004/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Needed for reverting:
https://codereview.chromium.org/1175313003.

Powered by Google App Engine
This is Rietveld 408576698