Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1175313003: Update test262-es6 to 6/11 (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Update test262-es6 to 6/11 This reverts commit 67b169199e06a486e7b663c7758f81995ddc6593 and picks up the fixes to the yaml parser upstream. BUG=N LOG=N R=adamk@chromium.org, machenbach@chromium.org Committed: https://crrev.com/bc847230610d0518a700a69546d23784e6ce3479 Cr-Commit-Position: refs/heads/master@{#29056}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+408 lines, -388 lines) Patch
M test/test262-es6/README View 1 chunk +2 lines, -2 lines 0 comments Download
M test/test262-es6/test262-es6.status View 1 5 chunks +392 lines, -383 lines 0 comments Download
M test/test262-es6/testcfg.py View 2 chunks +12 lines, -2 lines 0 comments Download
M tools/testrunner/local/statusfile.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 21 (8 generated)
arv (Not doing code reviews)
PTAL
5 years, 6 months ago (2015-06-11 20:08:48 UTC) #1
adamk
lgtm
5 years, 6 months ago (2015-06-11 20:10:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175313003/1
5 years, 6 months ago (2015-06-11 20:17:09 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/1263)
5 years, 6 months ago (2015-06-11 20:18:17 UTC) #6
Michael Achenbach
lgtm ~ rebase
5 years, 6 months ago (2015-06-12 07:35:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175313003/20001
5 years, 6 months ago (2015-06-16 21:35:49 UTC) #10
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
5 years, 6 months ago (2015-06-16 21:35:51 UTC) #12
Michael Achenbach
I don't know how this CL got target ref refs/pending/heads/test262-update - something must have gone ...
5 years, 6 months ago (2015-06-16 21:47:43 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1175313003/40001
5 years, 6 months ago (2015-06-16 21:48:32 UTC) #17
arv (Not doing code reviews)
On 2015/06/16 21:47:43, Michael Achenbach wrote: > I don't know how this CL got target ...
5 years, 6 months ago (2015-06-16 21:54:21 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 6 months ago (2015-06-16 22:15:58 UTC) #19
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/bc847230610d0518a700a69546d23784e6ce3479 Cr-Commit-Position: refs/heads/master@{#29056}
5 years, 6 months ago (2015-06-16 22:16:19 UTC) #20
Michael Achenbach
5 years, 6 months ago (2015-06-17 06:52:33 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/1186093005/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Please fix test expectations for nosnap
before reland. There are 54 tests failing:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds....

Powered by Google App Engine
This is Rietveld 408576698