Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2804)

Unified Diff: components/autofill/content/renderer/password_autofill_agent.h

Issue 1184913002: [Password Manager] Suppress UI when password generation is active (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_autofill_agent.h
diff --git a/components/autofill/content/renderer/password_autofill_agent.h b/components/autofill/content/renderer/password_autofill_agent.h
index f0f3267f9871b666b171f1284bd6ad621d0a6867..08e1cffd51ffd456fb9016f18cf4b28da79443b1 100644
--- a/components/autofill/content/renderer/password_autofill_agent.h
+++ b/components/autofill/content/renderer/password_autofill_agent.h
@@ -66,8 +66,13 @@ class PasswordAutofillAgent : public content::RenderFrameObserver {
// Shows an Autofill popup with username suggestions for |element|. If
// |show_all| is |true|, will show all possible suggestions for that element,
// otherwise shows suggestions based on current value of |element|.
+ // If |generation_popup_showing| is true, this function will return false
+ // as both UIs should not be shown at the same time. This function should
+ // still be called in this situation so that UMA stats can be logged.
// Returns true if any suggestions were shown, false otherwise.
- bool ShowSuggestions(const blink::WebInputElement& element, bool show_all);
+ bool ShowSuggestions(const blink::WebInputElement& element,
+ bool show_all,
+ bool generation_popup_showing);
// Called when new form controls are inserted.
void OnDynamicFormsSeen();

Powered by Google App Engine
This is Rietveld 408576698