Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: components/autofill/content/renderer/password_autofill_agent.h

Issue 1184913002: [Password Manager] Suppress UI when password generation is active (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_ 5 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_
6 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_ 6 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_
7 7
8 #include <map> 8 #include <map>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 const blink::WebString& password); 59 const blink::WebString& password);
60 60
61 // Clears the preview for the username and password fields, restoring both to 61 // Clears the preview for the username and password fields, restoring both to
62 // their previous filled state. Return false if no login information was 62 // their previous filled state. Return false if no login information was
63 // found for the form. 63 // found for the form.
64 bool DidClearAutofillSelection(const blink::WebNode& node); 64 bool DidClearAutofillSelection(const blink::WebNode& node);
65 65
66 // Shows an Autofill popup with username suggestions for |element|. If 66 // Shows an Autofill popup with username suggestions for |element|. If
67 // |show_all| is |true|, will show all possible suggestions for that element, 67 // |show_all| is |true|, will show all possible suggestions for that element,
68 // otherwise shows suggestions based on current value of |element|. 68 // otherwise shows suggestions based on current value of |element|.
69 // If |generation_popup_showing| is true, this function will return false
70 // as both UIs should not be shown at the same time. This function should
71 // still be called in this situation so that UMA stats can be logged.
69 // Returns true if any suggestions were shown, false otherwise. 72 // Returns true if any suggestions were shown, false otherwise.
70 bool ShowSuggestions(const blink::WebInputElement& element, bool show_all); 73 bool ShowSuggestions(const blink::WebInputElement& element,
74 bool show_all,
75 bool generation_popup_showing);
71 76
72 // Called when new form controls are inserted. 77 // Called when new form controls are inserted.
73 void OnDynamicFormsSeen(); 78 void OnDynamicFormsSeen();
74 79
75 // Called when an XHR has succesfully completed. Used to determine if 80 // Called when an XHR has succesfully completed. Used to determine if
76 // a form has been submitted by XHR without navigation. 81 // a form has been submitted by XHR without navigation.
77 void XHRSucceeded(); 82 void XHRSucceeded();
78 83
79 // Called when the user first interacts with the page after a load. This is a 84 // Called when the user first interacts with the page after a load. This is a
80 // signal to make autofilled values of password input elements accessible to 85 // signal to make autofilled values of password input elements accessible to
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
292 FormsPredictionsMap form_predictions_; 297 FormsPredictionsMap form_predictions_;
293 298
294 base::WeakPtrFactory<PasswordAutofillAgent> weak_ptr_factory_; 299 base::WeakPtrFactory<PasswordAutofillAgent> weak_ptr_factory_;
295 300
296 DISALLOW_COPY_AND_ASSIGN(PasswordAutofillAgent); 301 DISALLOW_COPY_AND_ASSIGN(PasswordAutofillAgent);
297 }; 302 };
298 303
299 } // namespace autofill 304 } // namespace autofill
300 305
301 #endif // COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_ 306 #endif // COMPONENTS_AUTOFILL_CONTENT_RENDERER_PASSWORD_AUTOFILL_AGENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698